Merge css() declarations into each element's own style (#107)

css() read the style attribute of every match into one map and wrote the
union back to all of them, so elements picked up each other's
declarations. Parse, merge and write per element instead.

Fixes #77.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Jake Jackson <jakejackson1@users.noreply.github.com>

Author: 3 people

CHANGELOG.md

@@ -33,6 +33,7 @@ QueryPath Changelog
 - Fix `tag()` emitting an "Undefined property" warning and returning `NULL` when the first match is not an element, such as a text, comment or processing instruction node returned by `contents()`. It now returns an empty string, as it does for an empty match set (issue #93)
 - Fix QueryPath's error handler staying installed for the rest of the request when an exception other than a `QueryPath\Exception` (a `TypeError`, or one thrown by a stream wrapper, for example) escaped from parsing a document, inserting markup, or `writeXML()`/`writeHTML()` (issue #95)
 - Fix `writeHTML()` throwing `QueryPath\ParseException` instead of `QueryPath\IOException` when the file cannot be written, as `writeXML()` and `writeHTML5()` do (issue #92). `IOException` extends `ParseException`, so existing `catch (ParseException $e)` blocks still catch it
+- Fix `css()` merging the inline styles of every matched element and writing the combined result back to all of them. The new declarations are now merged into each element's own `style` attribute (issue #77)
 - Fix `not()` keeping only the given nodes, instead of removing them, when passed an `SplObjectStorage` such as `get(null, true)` returns (issue #75)
 
 # 4.1.0

src/Helpers/QueryMutators.php

@@ -1040,9 +1040,11 @@ public function css($name = null, $value = '')
 			return $this->attr('style');
 		}
 
-		// Get any existing CSS.
-		$css = [];
+		$rules = is_array($name) ? $name : [$name => $value];
+
 		foreach ($this->elements() as $match) {
+			// Get this element's existing CSS.
+			$css   = [];
 			$style = $match->getAttribute('style');
 			if (! empty($style)) {
 				// XXX: Is this sufficient?
@@ -1059,23 +1061,18 @@ public function css($name = null, $value = '')
 					$css[$css_att] = trim($css_val);
 				}
 			}
-		}
 
-		if (is_array($name)) {
 			// Use array_merge instead of + to preserve order.
-			$css = array_merge($css, $name);
-		} else {
-			$css[$name] = $value;
-		}
+			$css = array_merge($css, $rules);
 
-		// Collapse CSS into a string.
-		$format     = '%s: %s;';
-		$css_string = '';
-		foreach ($css as $n => $v) {
-			$css_string .= sprintf($format, $n, trim($v));
-		}
+			// Collapse CSS into a string.
+			$css_string = '';
+			foreach ($css as $n => $v) {
+				$css_string .= sprintf('%s: %s;', $n, trim($v));
+			}
 
-		$this->attr('style', $css_string);
+			$match->setAttribute('style', $css_string);
+		}
 
 		return $this;
 	}

tests/QueryPath/DOMQueryTest.php

@@ -517,6 +517,24 @@ public function testCss()
 		$this->assertEquals('a: c;b: b;', $qp->css());
 	}
 
+	public function testCssMergesIntoEachElementsOwnStyle()
+	{
+		$html = '<div><p style="color: red"></p><p style="font-size: 2px; margin: 5px"></p><p></p></div>';
+
+		$qp = html5qp($html, 'p')->css('margin', '0');
+		$this->assertSame('color: red;margin: 0;', $qp->get(0)->getAttribute('style'));
+		$this->assertSame('font-size: 2px;margin: 0;', $qp->get(1)->getAttribute('style'));
+		$this->assertSame('margin: 0;', $qp->get(2)->getAttribute('style'));
+
+		$qp = html5qp($html, 'p')->css(['margin' => '0', 'color' => 'blue']);
+		$this->assertSame('color: blue;margin: 0;', $qp->get(0)->getAttribute('style'));
+		$this->assertSame('font-size: 2px;margin: 0;color: blue;', $qp->get(1)->getAttribute('style'));
+		$this->assertSame('margin: 0;color: blue;', $qp->get(2)->getAttribute('style'));
+
+		// The getter still returns the first element's style, unparsed.
+		$this->assertSame('color: red', html5qp($html, 'p')->css());
+	}
+
 	public function testRemoveAttr()
 	{
 		$file = DATA_FILE;