Skip to content

Move commentary out of the interval definition - #455

Merged
d-morrison merged 3 commits into
mainfrom
claude/project-thread-n2luz6
Oct 26, 2026
Merged

d-morrison merged 3 commits into
mainfrom
claude/project-thread-n2luz6

Conversation

@d-morrison

Copy link
Copy Markdown
Contributor

Fixes #454.

A definition div holds the definition, notation and display equation; commentary goes in a #rem- div (Morrison-Lab/sds#444 (comment)).

  • #def-interval loses its closing paragraph on bracket and parenthesis notation.
  • The paragraph moves to #rem-interval-brackets (own subfile), included after _def-interval.qmd (which holds six interval divs, so the remark cannot sit directly under #def-interval without a split). It is reworded slightly so the term-link check passes ("means", "square", "and", "not" are defined terms in mds).
  • Anchors are unchanged.

Not fixed here: #def-interval also bolds a second term (endpoints); the multi-div file is tracked by the one-div-per-subfile work.

Checked locally: check-term-links is clean. The f-form check was skipped (no macros submodule in this checkout; the remark's only math is \infty). No local render; please check the PR preview.

Owning thread: Bias is prediction error. Companion fixes: Morrison-Lab/sds#454 (merged), https://github.com/Morrison-Lab/lds/pull/1344 (merged), Morrison-Lab/pds#246.


Generated by Claude Code

Fixes #454. The paragraph on bracket and parenthesis notation moves to
#rem-interval-brackets, in its own subfile, included after the interval definitions.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JnPx8evH3UH3HERfjXrxht
@github-actions

This comment has been minimized.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JnPx8evH3UH3HERfjXrxht

Copy link
Copy Markdown
Contributor Author

/review
Posted by Claude Code (AI agent) --- not written by a human.


Generated by Claude Code

@github-actions

This comment has been minimized.

Copy link
Copy Markdown
Contributor Author

/review
Posted by Claude Code (AI agent) --- not written by a human.


Generated by Claude Code

@github-actions

Copy link
Copy Markdown
Contributor

Claude finished review — View run


Two small suggestions, nothing blocking. I read the diff and the surrounding _sets.qmd and _def-interval.qmd. I did not render the site.

The change moves the bracket/parenthesis explanation out of #def-interval into a new #rem-interval-brackets div. The new div is included after _def-interval.qmd. This fits the repo's "commentary goes in a separate #rem- div" rule. The link number-systems.qmd#def-real-numbers resolves, because #def-real-numbers exists in the number-systems page. No other file references the old prose, so no cross-reference breaks.

Suggestions (non-blocking)

  • _sets.qmd:88 (forward reference): _def-interval.qmd holds several divs, not only #def-interval. It also holds #def-closed-interval, the open and half-open interval definitions, and the unbounded-interval bullets. Those divs use [a, b], (a, b) and [a, \infty) in lines 33–70. The remark that explains the bracket convention is included only after all of them. A reader meets the notation before its explanation. Moving the include above the closed-interval div would fix this. The other option is to split _def-interval.qmd so the remark follows #def-interval directly.
  • _subfiles/sets/_rem-interval-brackets.qmd:6 (wording): "The symbols $\infty$, $-\infty$ denote no real number" is awkward. "The symbols $\infty$ and $-\infty$ are not real numbers" is clearer and matches the removed sentence. Also, [endpoint](#def-interval) links to the whole interval definition, because endpoint has no div of its own. That is acceptable, but it makes the link slightly vague.

The new prose does not add math that needs the semantic macros. \infty has no macro need here.

Verdict

Ready for merge

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "a6f776c65651cf4b907b1cfecff03cd7867465c3",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "The new remark file and its include in _sets.qmd are well-formed and the real-numbers link resolves; the only concern is that the closed and open interval definitions use bracket notation before the remark explains it.",
  "holistic_assessment": "The change is narrowly scoped, follows the separate rem-div convention, and breaks no anchors or cross-references; ordering of the include relative to later interval definitions is a non-blocking suggestion."
}

Reviewed commit: a6f776c

@github-actions

Copy link
Copy Markdown
Contributor

💰 Cost: $0.1934 (review) — run

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.

2026-10-26 20:02 UTC

@d-morrison
d-morrison merged commit 9760bc7 into main Oct 26, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move commentary out of #def-interval

3 participants