Repository navigation
Move commentary out of the interval definition - #455
Conversation
Fixes #454. The paragraph on bracket and parenthesis notation moves to #rem-interval-brackets, in its own subfile, included after the interval definitions. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JnPx8evH3UH3HERfjXrxht
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JnPx8evH3UH3HERfjXrxht
|
/review Generated by Claude Code |
This comment has been minimized.
This comment has been minimized.
|
/review Generated by Claude Code |
|
Claude finished review — View run Two small suggestions, nothing blocking. I read the diff and the surrounding The change moves the bracket/parenthesis explanation out of Suggestions (non-blocking)
The new prose does not add math that needs the semantic macros. VerdictReady for merge Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "a6f776c65651cf4b907b1cfecff03cd7867465c3",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "The new remark file and its include in _sets.qmd are well-formed and the real-numbers link resolves; the only concern is that the closed and open interval definitions use bracket notation before the remark explains it.",
"holistic_assessment": "The change is narrowly scoped, follows the separate rem-div convention, and breaks no anchors or cross-references; ordering of the include relative to later interval definitions is a non-blocking suggestion."
}Reviewed commit: a6f776c |
2026-10-26 20:02 UTC |
Fixes #454.
A definition div holds the definition, notation and display equation; commentary goes in a
#rem-div (Morrison-Lab/sds#444 (comment)).#def-intervalloses its closing paragraph on bracket and parenthesis notation.#rem-interval-brackets(own subfile), included after_def-interval.qmd(which holds six interval divs, so the remark cannot sit directly under#def-intervalwithout a split). It is reworded slightly so the term-link check passes ("means", "square", "and", "not" are defined terms in mds).Not fixed here:
#def-intervalalso bolds a second term (endpoints); the multi-div file is tracked by the one-div-per-subfile work.Checked locally: check-term-links is clean. The f-form check was skipped (no macros submodule in this checkout; the remark's only math is
\infty). No local render; please check the PR preview.Owning thread: Bias is prediction error. Companion fixes: Morrison-Lab/sds#454 (merged), https://github.com/Morrison-Lab/lds/pull/1344 (merged), Morrison-Lab/pds#246.
Generated by Claude Code