Skip to content

Retitle definitions with comma-list synonyms (batch 4) - #464

Merged
d-morrison merged 3 commits into
mainfrom
claude/sweep-def-titles-4
Oct 24, 2026
Merged

d-morrison merged 3 commits into
mainfrom
claude/sweep-def-titles-4

Conversation

@d-morrison

Copy link
Copy Markdown
Contributor

🤖 Generated with Claude Code

https://claude.ai/code/session_016qisJqZVehBBa5aL7y8VvN

Summary

Batch 4 of the definition-title sweep (psw#339 rule: synonyms as a comma list, primary term first). Seven files, titles only; div ids are unchanged.

Follows mds#463 (batch 3, green and clean).

Left for a later PR, pending a decision on titles that are not plain synonyms: natural numbers ("our convention"), convergent and divergent sequence (word forms), and norm ("normed space").


Generated by Claude Code

Part of the def-title synonym sweep (Morrison-Lab/psw#339). Ids unchanged.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016qisJqZVehBBa5aL7y8VvN
@github-actions

This comment has been minimized.

Copy link
Copy Markdown
Contributor Author

review / require-clean-verdict is red because the Claude review hit an API quota limit (429, resets 4:10pm PDT), not because of this diff. No verdict was produced for head 5ca1b99, so the PR is not clean yet.

In the meantime a read-only review by a separate agent, not the cross-harness review, found no issues: seven title lines changed, ids and bodies untouched, no words lost, no parentheses left. I'll re-run the Claude review after the reset.


Generated by Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016qisJqZVehBBa5aL7y8VvN
@github-actions

This comment has been minimized.

Copy link
Copy Markdown
Contributor Author

/review


Posted by Claude Code (AI agent) --- not written by a human.
Generated by Claude Code


Generated by Claude Code

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

…closure

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016qisJqZVehBBa5aL7y8VvN
@github-actions

Copy link
Copy Markdown
Contributor

Claude finished review — View run


Both blocking findings from the prior round are resolved in the new commit.

Review of PR #464 (head 4a526a2)

The prior round (the review posted 2026-10-23T23:51:09Z at #464 (comment), commit 3217ef1) gave Needs more work. It raised two title/body mismatches. The new commit 4a526a2 is the only commit since then. It touches two files:

  • _subfiles/linear-algebra/_def-subspace.qmd:
    • The body now reads "A subspace is also called a linear subspace." The aliases "vector space" and "linear space" are gone.
    • The title Subspace, linear subspace now matches the body's one bolded alias.
    • Dropping "vector space" also removes a misleading equation of a vector space with a subspace of $\reals^p$.
  • _subfiles/functions/_def-closed-under.qmd: "closure" is no longer bold. The body reads "This property is called closure under the operation." The title Closed under an operation and the body agree, and "closure" is no longer a bolded alias, so the alias rule isn't triggered.

Checks I ran:

  • The #def- IDs are unchanged, and @def-subspace is still referenced from other subfiles.
  • The diff adds no math, so the macro check does not apply.
  • I did not render the pages or run spell check or the link checker.

Verdict

Ready for merge. Both blocking findings from the prior round are fixed. The prior verdict no longer stands.

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "4a526a2bf40f611d1722acfe2411a6525afbfb25",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "The subspace definition title and body now agree on the single linear subspace alias, and closed-under no longer bolds closure as an alias beyond its title.",
  "holistic_assessment": "Scope stays limited to definition titles and alias prose with ids unchanged, so cross-site links are safe; no render or spell check was run."
}

Reviewed commit: 4a526a2

@github-actions

Copy link
Copy Markdown
Contributor

💰 Cost: $0.1614 (review) — run

@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.

2026-10-24 00:23 UTC

@d-morrison
d-morrison merged commit 4e3c3a0 into main Oct 24, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants