Skip to content

Add the self-credits check - #1397

Merged
dem-extra1 merged 1 commit into
mainfrom
claude/check-self-credits-adopt
Oct 22, 2026
Merged

dem-extra1 merged 1 commit into
mainfrom
claude/check-self-credits-adopt

Conversation

@dem-extra1

Copy link
Copy Markdown
Collaborator

Before: Nothing flagged a formal credit to the lab's own sites or works, so "adapted from" lines and citations of our own pages could be added unnoticed.

After: A warn-only check-self-credits check runs on pull requests that change .md or .qmd files. It flags an added line that cites a bibliography key for the group's own work, or that has a credit phrase beside the name or URL of one of the group's sites. Links for further reading are never flagged.

The check is the reusable workflow from Morrison-Lab/gha (merged in Morrison-Lab/gha#1147, part of Morrison-Lab/gha#1076, v3 tag moved). .github/own-works.yml lists the group's sites, names and authors, and .github/workflows/check-self-credits.yml is the thin caller. No content changes.


Generated by Claude Code

The lab does not formally acknowledge content borrowed from its own sites and
works (Ezra, 2026-10-16). Call Morrison-Lab/gha's check-self-credits on pull
requests, with the lists of own works in .github/own-works.yml. It warns on an
added line that cites an entry for the group's own work or has a credit phrase
beside the name or URL of one of its sites. Part of Morrison-Lab/gha#1076.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019o1foYS42VSzMN1M83J9Hr

Copy link
Copy Markdown
Collaborator Author

The link-checker check failed on this PR, and failed again on one re-run. This PR is not the cause: it adds only .github/own-works.yml and .github/workflows/check-self-credits.yml, which no page links to, so it changes no checked link. The job runs lychee over the whole tree, including external campus, Canvas and Springer URLs that redirect or require login. I could not download the full log from my session to name the exact failing URL, so I have not confirmed which one it is. No fix exists yet, and I am not widening this PR to cover it. I am keeping the PR watched.


Generated by Claude Code

@github-actions

Copy link
Copy Markdown
Contributor

Claude finished review — View run


All claims check out: PR #1147 and issue #1076 in Morrison-Lab/gha are real and match the description, the v3 tag of Morrison-Lab/gha does contain check-self-credits.yml/check-self-credits action with the exact inputs used, and .github/own-works.yml's schema (urls/names/authors/keys/allow-keys) parses cleanly against the action's config parser (unset allow-patterns/bib-globs default safely to empty). No fabricated APIs or references.

Other checks performed:

  • PR is open, not a draft, mergeable, no prior comments from Claude or anyone else on this PR.
  • This is a pure .github/ infra change with zero .qmd/.R files touched, so it correctly stays out of book-content PRs per CLAUDE.md's "Workflow / .github/ / CI / infra changes go in their own dedicated PRs" rule, and the mandatory render/lint/spell-check pre-commit checklist doesn't apply (no qmd/R changed).
  • Compared the new workflow's trigger/paths-ignore/pinning style against the repo's existing Morrison-Lab/gha thin-caller workflows (check-term-links.yml, check-new-line-breaks.yml, check-bibliography-dois.yml, etc.) — tag-pinning at @v3, contents: read permission, and paths-ignore: '_extensions/**,latex-macros/**' are all consistent with repo convention (_extensions/ is vendored, latex-macros/ is the d-morrison/macros submodule per .gitmodules).
  • No math changed in this diff (only two new workflow/config files), so the LaTeX-macro simplification/new-macro checks don't apply; latex-macros/macros.qmd exists in this repo but there's nothing in this diff to check it against.
  • YAML parses cleanly; the top-level pull_request.paths filter (restricting the job to PRs touching .md/.qmd/own-works.yml) is a reasonable CI-minutes optimization and doesn't conflict with the reusable workflow's own diff-scoping.
  • own-works.yml's restricted-YAML list syntax (key: + - item lines) matches what check-self-credits.py's parse_lists expects; unknown/extra keys would only warn, not error, and none are present here.

No bugs, CLAUDE.md violations, or hallucinated references found.

Verdict

Ready for merge

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "c9dd125f72432377dc54e7b105def3f180fe27b9",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "Checked .github/own-works.yml and check-self-credits.yml against the pinned Morrison-Lab/gha v3 action; schema, inputs, and paths-ignore globs all resolve correctly with no parse errors.",
  "holistic_assessment": "Infra-only change stays isolated from book content per CLAUDE.md, matches existing thin-caller workflow conventions, and introduces no regression risk to render, lint, or spelling checks."
}

Reviewed commit: c9dd125

@github-actions

Copy link
Copy Markdown
Contributor

💰 Cost: $0.4636 (review) — run

@dem-extra1
dem-extra1 merged commit b62266d into main Oct 22, 2026
29 of 32 checks passed
@dem-extra1
dem-extra1 deleted the claude/check-self-credits-adopt branch October 22, 2026 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants