Skip to content

Exclude three flaky outside hosts from the link check - #1406

Merged
d-morrison merged 1 commit into
mainfrom
exclude-flaky-link-hosts
Oct 23, 2026
Merged

d-morrison merged 1 commit into
mainfrom
exclude-flaky-link-hosts

Conversation

@d-morrison

Copy link
Copy Markdown
Collaborator

Infra only: adds three hosts to the exclude list in lychee.toml.

  • webhomes.maths.ed.ac.uk/~swood34/RCdebug/RCdebug.html: connection refused.
  • www-cs-students.stanford.edu/~blynn/gitmagic/: request timed out.
  • www.caut.ca/...guide-acknowledging-first-peoples-traditional-territory: request timed out.

They failed the link check on #1404 (run 39898743171) although no link in that PR changed.

Ezra approved the exclusion by typing "exclude them" in the project thread (message cmsg_014QLd5McmoUEgMPRiXeVnjS... as relayed by the coordinator: cmsg_014QLd5McmoUEgMPRiXeVnjSCjBknu1udnt6aVvriieu58).


Generated by Claude Code

They refuse connections or time out from CI runners, so unrelated PRs fail.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01V6MvQvUgPePB2ndiLAgpHs

Copy link
Copy Markdown
Collaborator Author

link-checker failed on d23d80f, but not on the three excluded hosts. Those no longer appear in the errors.

The only errors were 503s from https://morrison-lab.github.io/mds/optimization.html#def-strictly-convex, in three subfiles. That page returns 200 now, so it looks like a transient Pages outage. Nothing in this diff touches those links.

I'm re-running the job once.


Generated by Claude Code

@github-actions

Copy link
Copy Markdown
Contributor

Claude finished review — View run


The macro check is N/A here — this PR touches only lychee.toml, a TOML config file with no LaTeX math, so there's nothing to check against latex-macros/macros.qmd.

Review: #1406 — Exclude three flaky outside hosts from the link check

This is a minimal, infra-only change to lychee.toml adding three hosts to the exclude list, matching the PR's stated description.

Verification performed:

  • Confirmed via gh run view 39898743171 --log that all three excluded URLs (webhomes.maths.ed.ac.uk/~swood34/RCdebug/RCdebug.html, www-cs-students.stanford.edu/~blynn/gitmagic/*, caut.ca/content/guide-acknowledging-first-peoples-traditional-territory) actually failed on that run with connection-refused/timeout errors, not 404s — so excluding them (rather than fixing a genuinely dead link) is the right call, per the file's own convention distinguishing transient-failure exclusions (top block) from truly-dead links (bottom block, with a TODO to fix and remove).
  • The new entries are placed in the correct section (grouped with the other "site blocks CI runners" exclusions, above the "already dead" block), each with an explanatory comment following the established pattern.
  • Pattern syntax is internally consistent with the rest of the file: exact-string entries for single-page hosts, and a .* wildcard suffix for www-cs-students.stanford.edu because the CI log shows two distinct paths under that host (/~blynn/gitmagic/ and /~blynn/gitmagic/ch01.html) both timing out — the wildcard is necessary, not just stylistic.
  • No _subfiles/ were touched, so the "clear freezer" label requirement doesn't apply. No math/macro content, no R/.qmd content changes, so lint/spell/render pre-commit checks don't apply either — this is a workflow/CI-adjacent config change, which per CLAUDE.md should live in "its own dedicated PR" separate from book-content, and it does.
  • No AI-hallucination concerns: the hosts, the CI run reference, and the comment text all check out against the actual run log.

No issues found.

Verdict

Ready for merge

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "df9c99c",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "Checked lychee.toml's three new exclude entries against the actual CI run log (39898743171) and confirmed each URL failed with connection-refused or timeout, not a dead-link 404, matching the file's existing convention for transient-failure exclusions.",
  "holistic_assessment": "Change is scoped correctly as an infra-only config PR separate from book content, requires no render/lint/spell checks, and the regex wildcard choice for the Stanford host is justified by two distinct failing paths in the log."
}

Reviewed commit: d23d80f

@github-actions

Copy link
Copy Markdown
Contributor

💰 Cost: $0.2444 (review) — run

@d-morrison
d-morrison merged commit 86e7f76 into main Oct 23, 2026
28 of 29 checks passed
@d-morrison
d-morrison deleted the exclude-flaky-link-hosts branch October 23, 2026 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants