Skip to content

Bump latex-macros so the logistic function prints as expit - #1409

Merged
d-morrison merged 1 commit into
mainfrom
claude/project-thread-gz6w0h
Oct 25, 2026
Merged

d-morrison merged 1 commit into
mainfrom
claude/project-thread-gz6w0h

Conversation

@d-morrison

Copy link
Copy Markdown
Collaborator

Requested by Ezra · project thread

Bumps the latex-macros pin to 605844f, which includes macros#294: \sigmoid and \sigmoidf now print upright expit instead of σ, which also prints a standard deviation, a bandwidth and a singular value. The names stay as permanent aliases (macros#295), so no source change is needed. Pin-only change; not rendered locally.


Generated by Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DcoxKs4KBbN2HfeyoeUw5h
@d-morrison d-morrison self-assigned this Oct 25, 2026

Copy link
Copy Markdown
Collaborator Author

/review


Posted by Claude Code (AI agent) --- not written by a human.
Generated by Claude Code


Generated by Claude Code

@github-actions

Copy link
Copy Markdown
Contributor

Claude finished review — View run


The new pin SHA is the tip of main on d-morrison/macros, matching the submodule's tracked branch — confirmed.

Review: PR #1409 — Bump latex-macros so the logistic function prints as expit

Summary: A one-line submodule pointer bump (latex-macros: 16d943c7 → 605844f5), pulling in d-morrison/macros#294 and #295.

Verification performed:

No issues found — this is a correct, minimal, well-described submodule bump with an accurate PR description, verified against the actual upstream commits and against rme's own usage of the affected macros.

Verdict

Ready for merge

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "d80da014579c0ca7981b308d763f34f2695d6e3d",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "The latex-macros pointer bump introduces no changes to rme's own qmd files, and sigmoid/sigmoidf are unused in rme content, so the new expit rendering is a verified no-op risk.",
  "holistic_assessment": "Scope stays narrow as a submodule pin bump, integration with rme's include-only-macros.qmd pattern is unaffected, and CI validation is green aside from unrelated still-pending jobs."
}

Reviewed commit: d80da01

@github-actions

Copy link
Copy Markdown
Contributor

💰 Cost: $0.3891 (review) — run

@github-actions

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
🚀 Preview available at: https://Morrison-Lab.github.io/rme/pr-preview/pr-1409/

Built to branch gh-pages at 2026-10-25 01:53 UTC.

@d-morrison
d-morrison merged commit e238868 into main Oct 25, 2026
28 checks passed
@d-morrison
d-morrison deleted the claude/project-thread-gz6w0h branch October 25, 2026 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants