Landing Guidance is evil and freaks out

[PewPewCricket]

MechJeb Version

2.15.3.0

KSP Version

12.5

Description

Landing Guidance freaks the fuck out right before touchdown on landing and sets the throttle to max and then starts flipping around. Tested on both Minmus and the Mun. Also it does not timewarp on its own unless i manually do it where it then takes over for me.

Replication Case

The .ckan file for my modlist is attached. Here is a video of the behavior.
You have to rename the .ckan.txt to .txt because github sucks.
RENAME_ME-evil-ass-modpack.ckan.txt

KSP.log

KSP.log

[Nazfib]

Finally had a chance to look at your video.

You have "keep limited throttle over" enabled, and set to 5%. This setting was designed for RealismOverhaul, where engines have a limited number of ignitions; if this is checked, then MJ will not throttle down below 5%, and therefore not shut down the engine during the final landing burn. In your case, even when the throttle is all the way down at 5%, your vessel still has more thrust than weight; MJ cannot throttle down enough to land, and this causes the guidance to freak out. Since you're not playing with limited engine ignitions, I recommend just disabling "keep limited throttle over" setting and letting MJ shut down the engine if it thinks that's necessary.

Regarding the autowarp issue; MJ only starts warping when the vessel is pointing in the correct direction, and has stopped rotating. One change in the latest version of MJ, is that it no longer automatically kills your roll rotation in many cases; but the autowarp system does not take this into account. Currently, only the node executor and ascent guidance have toggles to select if they control the roll rate; for all other autopilots, the roll rate is not damped anymore by default, which means autowarp will not start anymore for those autopilots.

---

@lamont-granquist, what I'm proposing here is to set the default for the killRollRotation flag to true here:

MechJeb2/MechJeb2/MechJebModuleAttitudeController.cs

Line 265 in c5a6d8f

public void attitudeTo(Vector3d direction, AttitudeReference reference, object controller, bool killRollRotation = false)

Then, all autopilots except the node executor will automatically kill roll rotation; and autowarp will work again for all autopilots that check the angular velocity.

Alternatively, I can update all the places where the Vector3 version of attitudeTo is used, to make them use the Core.Node.KillRollRotation flag; and change all the locations where the angular velocity is checked, to ignore the roll component. In that case, all autopilots will (by default — this can be overriden with the toggle in the Node Executor) leave the vessel rolling in RO, and kill roll rotation otherwise.

Finally, does it make sense to set the LimitedMinThrottle setting off by default, and enable it by default in only in RO?