Skip to content

fix(stores): remove unused claimWinnings import (TS6133) - #5

Closed
BlacKSnowDot0 wants to merge 1 commit into
mainfrom
agent/market-unused-import
Closed

fix(stores): remove unused claimWinnings import (TS6133)#5
BlacKSnowDot0 wants to merge 1 commit into
mainfrom
agent/market-unused-import

Conversation

@BlacKSnowDot0

Copy link
Copy Markdown

Problem

Market's gate was red on main @ 2eb130e: typecheck fails with TS6133'claimWinnings' is declared but its value is never read — in application/src/stores/onchain.store.ts:6.

The store imports both claimWinnings and claimAnyWinnings, but only ever calls claimAnyWinnings (the kind-aware wrapper). claimWinnings in the import list is dead weight, and noUnusedLocals: true makes it a hard error.

Change

One line: remove claimWinnings from the import statement. Nothing else — all six remaining imports on that line are each used exactly once (verified).

Verification (evidence bundle)

Step Result Evidence
Fail-first on clean HEAD TS6133 at 6:50 — column count matches exactly where claimWinnings sits fail-before.txt
Full gate after fix PASS — typecheck (113 files) + lint + 51 api tests + 76 web tests + build gate-pass.log (pinned @ 2eb130e)
Adversarial review (cross-model, Kimi K3) APPROVE — 9 attack vectors survived review-verdict.txt

Notable review checks: kept import claimAnyWinnings confirmed used at onchain.store.ts:246; repo-wide grep confirms nothing else references claimWinnings (no mocks can break); reviewer independently re-ran azeroth check itself — exit 0. claimWinnings remains legitimately used internally by claimAnyWinnings (contracts.ts:240), so this is an import fix, not dead-code deletion.

Assumptions

  • The exported claimWinnings API in contracts.ts stays (reviewer recommends keeping; de-exporting would be a separate API-surface decision)

Generated autonomously (watcher/implementer: GLM-5.3, fail-first evidence → fix → full gate → reviewer: Kimi K3 adversarial approve). Human review required before merge.

TS6133: claimWinnings was imported but never used in onchain.store.ts;
only claimAnyWinnings (the kind-aware wrapper) is called. Remove the
dead import so typecheck passes.
@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@GreatRedem GreatRedem closed this Sep 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants