fix(stores): remove unused claimWinnings import (TS6133) - #5
Closed
BlacKSnowDot0 wants to merge 1 commit into
Closed
fix(stores): remove unused claimWinnings import (TS6133)#5BlacKSnowDot0 wants to merge 1 commit into
BlacKSnowDot0 wants to merge 1 commit into
Conversation
TS6133: claimWinnings was imported but never used in onchain.store.ts; only claimAnyWinnings (the kind-aware wrapper) is called. Remove the dead import so typecheck passes.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Market's gate was red on
main@2eb130e: typecheck fails with TS6133 —'claimWinnings' is declared but its value is never read— inapplication/src/stores/onchain.store.ts:6.The store imports both
claimWinningsandclaimAnyWinnings, but only ever callsclaimAnyWinnings(the kind-aware wrapper).claimWinningsin the import list is dead weight, andnoUnusedLocals: truemakes it a hard error.Change
One line: remove
claimWinningsfrom the import statement. Nothing else — all six remaining imports on that line are each used exactly once (verified).Verification (evidence bundle)
claimWinningssitsfail-before.txtgate-pass.log(pinned @ 2eb130e)review-verdict.txtNotable review checks: kept import
claimAnyWinningsconfirmed used atonchain.store.ts:246; repo-wide grep confirms nothing else referencesclaimWinnings(no mocks can break); reviewer independently re-ranazeroth checkitself — exit 0.claimWinningsremains legitimately used internally byclaimAnyWinnings(contracts.ts:240), so this is an import fix, not dead-code deletion.Assumptions
claimWinningsAPI incontracts.tsstays (reviewer recommends keeping; de-exporting would be a separate API-surface decision)Generated autonomously (watcher/implementer: GLM-5.3, fail-first evidence → fix → full gate → reviewer: Kimi K3 adversarial approve). Human review required before merge.