Repository navigation
feat(environment): update control size support - #1133
Conversation
|
👀 Human review needed JustificationThis PR modifies Beyond the opt-out, the change is broad and touches sensitive build/dependency surfaces:
Static analysis only; CI owns build and test verification. Reviewed commit d2b49b8 |
| case extraLarge | ||
|
|
||
| public static var allCases: [ControlSize] { | ||
| [.mini, .small, .regular, .large, .extraLarge] |
There was a problem hiding this comment.
allCases is always available but now returns .large and .extraLarge, whose cases are gated by later availability. Callers targeting earlier supported OS versions can observe those values without an availability check, which breaks the API availability contract.
Severity: medium
🤖 Was this useful? React with 👍 or 👎
| set { self[ControlSizeKey.self] = newValue } | ||
| } | ||
|
|
||
| package var explicitControlSize: ControlSize? { |
There was a problem hiding this comment.
This change adds the new explicitControlSize semantics, but there is no committed test that distinguishes an unset value (controlSize == .regular with explicitControlSize == nil) from an explicitly set .regular. That distinction is the main behavior added here, so future environment-key changes could regress it without CI coverage.
Severity: medium
🤖 Was this useful? React with 👍 or 👎
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1133 +/- ##
==========================================
- Coverage 30.89% 26.56% -4.33%
==========================================
Files 880 821 -59
Lines 71040 61722 -9318
==========================================
- Hits 21945 16399 -5546
+ Misses 49095 45323 -3772 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🛠️ Tuist Run Report 🛠️Tests 🧪
Builds 🔨
|
Summary
Validation
Scoped compilation, API access checks, and focused environment behavior checks passed with cached dependencies. Full package and UI builds were not run.