Repository navigation
fix(text): preserve macOS font smoothing in keyed text masks - #1141
Merged
Merged
Conversation
🛠️ Tuist Run Report 🛠️Tests 🧪
Builds 🔨
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1141 +/- ##
==========================================
- Coverage 30.01% 30.00% -0.01%
==========================================
Files 921 921
Lines 73240 73254 +14
==========================================
+ Hits 21982 21983 +1
- Misses 51258 51271 +13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
/interactiontest macos openswiftui-renderer-iag |
Kyle-Ye
force-pushed
the
fix/macos-keyed-text-mask
branch
from
October 12, 2026 15:32
6347bb5 to
13b2806
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1140.
Summary
macOS button labels differ from SwiftUI at the glyph edges because
renderKeyedTextdraws the alpha-only mask with white. macOS font smoothing usesthe fill color when it computes glyph coverage, including in an alpha-only
context.
existing rendering layer.
Validation
Both Button interaction cases passed on macOS 15.7.3 with the OpenSwiftUI
renderer and IAG. All six snapshots matched the unchanged SwiftUI references;
the action-count and disabled-action assertions also passed. This validation
was completed before the rebase onto the current
mainand has not beenrepeated after it.
A standalone text probe confirmed color-dependent alpha coverage on macOS
15.7.3 with font smoothing enabled. The equivalent iOS 18.5 probe was
color-independent.