Repository navigation
feat(slider): update Slider to the style configuration API - #1215
Merged
Merged
Conversation
Build the slider body from SliderStyleConfiguration and ResolvedSliderStyle. Store slider marks, round the discrete value count, and add the SPI initializer that takes a SliderStyleConfiguration.
- Add AccessibilityAdjustmentDirection and accessibilityAdjustableAction(_:) - Add AccessibilityAdjustableModifier and AccessibilitySliderModifier - Add accessibility value and set-value action helpers - Apply AccessibilitySliderModifier in Slider
- Add SPI SliderStyle, SliderStyleConfiguration and View.sliderStyle(_:) - Replace AnySliderStyle and SliderStyleKey with the style modifier system
- Add SPI SliderMark, SliderMarkBuilder and the Slider marks initializers
- Add SPI AutomaticSliderStyle and SliderStyle.automatic
Member
Author
|
/uitest osui-iag update only-testing=OpenSwiftUIUITests/SliderUITests |
github-actions
Bot
added
area: accessibility
🛠️ Tuist Run Report 🛠️Tests 🧪
Builds 🔨
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1215 +/- ##
==========================================
- Coverage 26.95% 26.93% -0.03%
==========================================
Files 890 893 +3
Lines 65866 66058 +192
==========================================
+ Hits 17756 17794 +38
- Misses 48110 48264 +154 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
github-actions
Bot
added
the
area: tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1154