Skip to content

fix: correct UnitCurve cubic interpolation - #1218

Merged
Kyle-Ye merged 1 commit into
mainfrom
bugfix/unit_curve
Oct 25, 2026
Merged

Kyle-Ye merged 1 commit into
mainfrom
bugfix/unit_curve

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Oct 25, 2026

Copy link
Copy Markdown
Member

Summary

  • Preserve Bezier y control points so curves can overshoot or undershoot the unit interval.
  • Correct cubic-solver fallback bounds, iteration limits, and NaN handling.
  • Add unit and compatibility regression coverage for control-point clamping, fallback endpoints, and non-finite inputs.

@github-actions github-actions Bot added area: animation Animation, transitions, transactions, or timing behavior. type: bug Something is not working correctly. labels Oct 25, 2026
@tuist

tuist Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

🛠️ Tuist Run Report 🛠️

Tests 🧪

Scheme Status Ran test modules Commit
OpenSwiftUI ✅ 7 add1dc1b8

Builds 🔨

Scheme Status Duration Commit
OpenSwiftUI ✅ 2m 17s add1dc1b8

@codecov

codecov Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 31.31%. Comparing base (9c53328) to head (c24ce68).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...penSwiftUICore/Animation/Animation/UnitCurve.swift 97.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1218      +/-   ##
==========================================
+ Coverage   31.28%   31.31%   +0.02%     
==========================================
  Files         968      968              
  Lines       78373    78371       -2     
==========================================
+ Hits        24521    24540      +19     
+ Misses      53852    53831      -21     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye
Kyle-Ye merged commit b78560b into main Oct 25, 2026
6 checks passed
@Kyle-Ye
Kyle-Ye deleted the bugfix/unit_curve branch October 25, 2026 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: animation Animation, transitions, transactions, or timing behavior. type: bug Something is not working correctly.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant