update

Author: svnv-svsv-jm

Chapter09/customer-support/src/customer_support/__main__.py

@@ -20,8 +20,8 @@ class Ingest(KnowledgeSettings):
     """Sync the source folder into the knowledge base."""
 
     def cli_cmd(self) -> None:
-        """Open the knowledge base and sync the folder."""
-        KnowledgeBase(self).sync()
+        """Sync the folder and print the report as JSON."""
+        print(KnowledgeBase(self).sync().model_dump_json())
 
 
 class ChatResult(Answer):

Chapter09/customer-support/src/customer_support/api.py

@@ -1,11 +1,30 @@
-from fastapi import FastAPI
+from typing import Annotated
 
+from fastapi import Depends, FastAPI
+
+from .config import Settings
+from .knowledge import KnowledgeBase, SyncReport
 from .response_models import HealthResponse
 
 app = FastAPI(title="Customer Support")
 
 
+def get_knowledge_base() -> KnowledgeBase:
+    """Open the knowledge base configured by the environment."""
+    return KnowledgeBase(Settings().knowledge)
+
+
 @app.get("/health")
 def health() -> HealthResponse:
     """Report that the service is up."""
     return HealthResponse(status="ok")
+
+
+@app.post("/knowledge/sync")
+def sync_knowledge(
+    knowledge_base: Annotated[
+        KnowledgeBase, Depends(get_knowledge_base)
+    ],
+) -> SyncReport:
+    """Sync the source folder into the knowledge base."""
+    return knowledge_base.sync()

Chapter09/customer-support/src/customer_support/knowledge.py

@@ -16,7 +16,6 @@
 from llama_index.core.storage.docstore import SimpleDocumentStore
 from llama_index.embeddings.fastembed import FastEmbedEmbedding
 from llama_index.vector_stores.chroma import ChromaVectorStore
-from loguru import logger
 from pydantic import BaseModel
 
 from .config import KnowledgeSettings
@@ -192,7 +191,6 @@ def sync(self) -> SyncReport:
         self._pipeline(docstore).run(documents=documents)
         docstore.persist(str(self._docstore_path))
         report = SyncReport.compare(stored, documents)
-        logger.info("Knowledge base synced: {}", report)
         return report
 
     def search(self, query: str, limit: int = 3) -> list[Chunk]:

Chapter09/customer-support/tests/conftest.py

@@ -287,30 +287,6 @@ def hosted_settings() -> LLMSettings:
     return LLMSettings(provider="openai", model="gpt-4o-mini")
 
 
-@pytest.fixture
-def changed_llm_environment(
-    monkeypatch: pytest.MonkeyPatch,
-) -> LLMSettings:
-    """Non-default configuration read from environment variables."""
-    expected = LLMSettings(
-        provider="openai",
-        model="gpt-4o-mini",
-        retrieval_limit=5,
-        request_limit=7,
-    )
-    prefix = "CUSTOMER_SUPPORT_LLM_"
-    for field in (
-        "provider",
-        "model",
-        "retrieval_limit",
-        "request_limit",
-    ):
-        monkeypatch.setenv(
-            prefix + field.upper(), str(getattr(expected, field))
-        )
-    return expected
-
-
 @pytest.fixture
 def database_settings(tmp_path: Path) -> DatabaseSettings:
     """On-disk SQLite database isolated to this test."""

Chapter09/customer-support/tests/test_api.py

@@ -9,5 +9,21 @@ def test_health(client: TestClient) -> None:
     assert response.json() == {"status": "ok"}
 
 
+@pytest.mark.usefixtures("ingestion_environment")
+def test_sync_endpoint_reports_changes(
+    client: TestClient, sample_sources: list[str]
+) -> None:
+    """Sync twice through the API and read both reports."""
+    first = client.post("/knowledge/sync")
+    assert first.status_code == 200
+    assert first.json()["added"] == sample_sources, (
+        "The first sync must add every sample document."
+    )
+    second = client.post("/knowledge/sync").json()
+    assert second["unchanged"] == sample_sources, (
+        "The second sync must find nothing to re-embed."
+    )
+
+
 if __name__ == "__main__":
     pytest.main([__file__, "-x", "-s"])