Skip to content

Commit 255eac7

Browse files
blafourcadeclaude
andauthored
ci(framework): exempt bot commits from DCO; drop admin names from docs (#186)
The DCO check now skips commits authored by a bot ([bot]), so release-please and Dependabot PRs are not blocked by a missing sign-off (the DCO applies to human contributions). Also removes the explicit admin member list from MAINTAINERS.md. Signed-off-by: Baptiste LAFOURCADE <baptiste.lafourcade@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 09dc949 commit 255eac7

2 files changed

Lines changed: 7 additions & 1 deletion

File tree

‎.github/workflows/dco.yml‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,12 @@ jobs:
4141
echo "skip merge commit ${sha}"
4242
continue
4343
fi
44+
# Skip commits authored by a bot (release-please, dependabot, ...);
45+
# the DCO applies to human contributions.
46+
author_name="$(git show -s --format='%an' "${sha}")"
47+
case "${author_name}" in
48+
*"[bot]") echo "skip bot commit ${sha} (${author_name})"; continue ;;
49+
esac
4450
if git show -s --format='%B' "${sha}" | grep -qiE "^Signed-off-by: .+ <.+@.+>"; then
4551
echo "ok ${sha}"
4652
else

‎docs/MAINTAINERS.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ Versions live in `.release-please-manifest.json`. Forcing a version / pre-releas
4242

4343
Two bypass actors (both `pull_request` mode, so neither can push directly to `main`):
4444
- the **aidd-bot GitHub App** (`Integration`) - release-please and the Dependabot auto-merge mint a token from it (`actions/create-github-app-token`), so their PRs trigger the required checks *and* the App merges them past the human-review rule.
45-
- the **`admin` team** (`alexsoyes`, `blafourcade`, `victor-langlois`) - lead maintainers can merge their own PR without a second review. Everyone else needs a code-owner review.
45+
- the **`admin` team** - lead maintainers can merge their own PR without a second review. Everyone else needs a code-owner review.
4646

4747
The App: ID in secret `AIDD_BOT_APP_ID`, key in `AIDD_BOT_PRIVATE_KEY`. If the App is broken/uninstalled, release and Dependabot PRs stop merging - fix the App rather than re-adding an admin bypass.
4848

0 commit comments

Comments
 (0)