Skip to content

Commit 5e8705c

Browse files
blafourcadeclaude
andcommitted
ci(framework): remove DCO sign-off requirement
Drop the Developer Certificate of Origin enforcement that was failing pipelines on unsigned commits: - delete .github/workflows/dco.yml (the only enforcement) - remove the DCO required status check from .github/rulesets/main.json (the live ruleset already lacked it; this realigns the file with live) - strip DCO references from CONTRIBUTING.md, README.md, MAINTAINERS.md, and the PR template Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Baptiste LAFOURCADE <baptiste.lafourcade@gmail.com>
1 parent 7cfc0a3 commit 5e8705c

6 files changed

Lines changed: 10 additions & 84 deletions

File tree

‎.github/PULL_REQUEST_TEMPLATE.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
Walk a reviewer through the technical resolution: the approach you took, why
1515
this way over the alternatives, and anything non-obvious (trade-offs, edge
1616
cases, follow-ups). This narrative is the point of the PR. The conventional
17-
title, DCO sign-off, and pre-commit hooks are already enforced by CI, so don't
17+
title and pre-commit hooks are already enforced by CI, so don't
1818
re-assert them here. Spend your words on the *how*.
1919
-->
2020

‎.github/rulesets/main.json‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,7 @@
2929
"strict_required_status_checks_policy": false,
3030
"required_status_checks": [
3131
{"context": "lefthook (framework-local checks)"},
32-
{"context": "Commitlint"},
33-
{"context": "Verify Developer Certificate of Origin sign-off"}
32+
{"context": "Commitlint"}
3433
]
3534
}
3635
},

‎.github/workflows/dco.yml‎

Lines changed: 0 additions & 66 deletions
This file was deleted.

‎CONTRIBUTING.md‎

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ flowchart TD
1515
Who{"Your profile?"}
1616
Pub["Public - discuss, react, upvote"]
1717
Core["Core Team - vote on roadmap priority"]
18-
Cert["Certifie AIDD - branch, commit (DCO), open PR"]
18+
Cert["Certifie AIDD - branch, commit, open PR"]
1919
Rev["Habilite AIDD - review (CODEOWNERS)"]
2020
Merge["Habilite AIDD - merge, release-please ships"]
2121
@@ -106,10 +106,10 @@ No live reload - run `codex plugin marketplace upgrade` after each change to ref
106106

107107
## 2. Commit
108108

109-
Format: `<type>(<scope>): description`, **signed off** for the [DCO](https://developercertificate.org/).
109+
Format: `<type>(<scope>): description`.
110110

111111
```bash
112-
git commit -s -m "feat(aidd-dev): add for-sure skill"
112+
git commit -m "feat(aidd-dev): add for-sure skill"
113113
```
114114

115115
**Scope** - one per commit (split cross-plugin changes):
@@ -125,19 +125,12 @@ git commit -s -m "feat(aidd-dev): add for-sure skill"
125125
- `feat` → minor · `fix` / `perf` → patch · `!` or `BREAKING CHANGE:` → major
126126
- `docs` / `refactor` / `style` / `test` / `build` / `ci` / `chore` → no release
127127

128-
**DCO** - `-s` adds the `Signed-off-by` trailer. Forgot one?
129-
130-
```bash
131-
git commit --amend --signoff # last commit
132-
git rebase --signoff origin/main # whole branch
133-
```
134-
135-
The [`DCO`](./.github/workflows/dco.yml) check fails any unsigned commit. Versioning and the release bundles are automated - see [Releases](#releases).
128+
Versioning and the release bundles are automated - see [Releases](#releases).
136129

137130
## 3. Open a pull request
138131

139132
- Work on a branch, not `main`.
140-
- **Fill the PR template** (applied automatically): explain *what* changed and *how* you resolved it technically - that narrative is the point of the PR. The conventional title, DCO sign-off, and pre-commit hooks are already enforced by CI, so don't spend the description re-asserting them.
133+
- **Fill the PR template** (applied automatically): explain *what* changed and *how* you resolved it technically - that narrative is the point of the PR. The conventional title and pre-commit hooks are already enforced by CI, so don't spend the description re-asserting them.
141134
- **Label the PR** so reviewers and the [Roadmap board](https://github.com/orgs/ai-driven-dev/projects/8) triage at a glance:
142135

143136
| Label | When to use |

‎README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,7 @@ Install issues, load problems, and the framework's current limits → [`docs/TRO
316316

317317
## Contributing
318318

319-
Everyone can shape this project. **Anyone** can open issues, react, and upvote ideas in [Discussions](https://github.com/ai-driven-dev/framework/discussions) (a signal); a counted roadmap vote is a benefit of **Core Team** membership in the [AIDD](https://www.ai-driven-dev.fr/) programme (training/community/coaching) and up, and **pull-request rights** are held by [Certifié and Habilité contributors](./GOVERNANCE.md#roles) so the standard stays consistent. Contributions are made under the [DCO](./CONTRIBUTING.md#2-commit) (sign off with `git commit -s`). See [`CONTRIBUTING.md`](./CONTRIBUTING.md) for the contribution flow, the commit scope discipline, and the templates each surface (skill, agent, rule, command) follows, and [`GOVERNANCE.md`](./GOVERNANCE.md) for the roles and how decisions get made.
319+
Everyone can shape this project. **Anyone** can open issues, react, and upvote ideas in [Discussions](https://github.com/ai-driven-dev/framework/discussions) (a signal); a counted roadmap vote is a benefit of **Core Team** membership in the [AIDD](https://www.ai-driven-dev.fr/) programme (training/community/coaching) and up, and **pull-request rights** are held by [Certifié and Habilité contributors](./GOVERNANCE.md#roles) so the standard stays consistent. See [`CONTRIBUTING.md`](./CONTRIBUTING.md) for the contribution flow, the commit scope discipline, and the templates each surface (skill, agent, rule, command) follows, and [`GOVERNANCE.md`](./GOVERNANCE.md) for the roles and how decisions get made.
320320

321321
To build and ship a brand-new plugin through this marketplace, see [`docs/CREATE_PLUGIN.md`](docs/CREATE_PLUGIN.md).
322322

‎docs/MAINTAINERS.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ How to operate this repository day to day. For **who** may do what and the decis
1717

1818
- **Triage issues.** New issues auto-add to board #8. Set `Status` / `Area` / `Priority` / `Work Type`; link under an epic (native sub-issues) if relevant.
1919
- **Roadmap.** Priority is set by the community vote (mechanism in `GOVERNANCE.md`). Accepted items live on board #8 - keep `ROADMAP.md` as a pointer, do not maintain a second list.
20-
- **Review PRs.** Every PR needs a Habilité (CODEOWNERS) approval; checks `lefthook`, `Commitlint`, `DCO` must pass; squash-merge.
20+
- **Review PRs.** Every PR needs a Habilité (CODEOWNERS) approval; checks `lefthook`, `Commitlint` must pass; squash-merge.
2121

2222
## Releases
2323

@@ -38,7 +38,7 @@ Versions live in `.release-please-manifest.json`. Forcing a version / pre-releas
3838

3939
## Branch protection & the bot bypass
4040

41-
`main` accepts only PRs (no direct push, no force-push, no deletion) with a CODEOWNERS review and passing `lefthook` / `Commitlint` / `DCO`.
41+
`main` accepts only PRs (no direct push, no force-push, no deletion) with a CODEOWNERS review and passing `lefthook` / `Commitlint`.
4242

4343
Two bypass actors (both `pull_request` mode, so neither can push directly to `main`):
4444
- the **aidd-bot GitHub App** (`Integration`) - release-please and the Dependabot auto-merge mint a token from it (`actions/create-github-app-token`), so their PRs trigger the required checks *and* the App merges them past the human-review rule.

0 commit comments

Comments
 (0)