You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit bf23db6
Browse filesBrowse the repository at this point in the historyBrowse files
ci: hold the release until its video is attached (#1093)
* ci: hold the release until its video is attached
The release was published once its bundle and distributions were attached,
video or not, and its publication is what n8n announces on Discord and Skool.
A release whose video failed was announced without it. The video is now
required: a failed video keeps the release a draft.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019tw8HkVy69fuukqR971Roz
* ci: remove the way to skip the release video check
The video is required for the release to publish, so a promotion that skips
its coverage check only moves the failure to release day.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019tw8HkVy69fuukqR971Roz
---------
Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
Copy file name to clipboardExpand all lines: RELEASE.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -38,7 +38,7 @@ flowchart LR
38
38
2. Open the [promotion `next` to `main`](https://github.com/ai-driven-dev/framework/actions/workflows/promote.yml) once the week's work is ready.
39
39
3. release-please opens a Release PR on `main`: it is auto-merged.
40
40
4. Tags and version bumps are created. The umbrella release is a draft: the bundle, the distributions and the rendered video are attached to it, then it is published. Announcements fire on that publication, with everything in place.
41
-
5. The video is rendered by CI from the plan the promotion checked. A failed video does not hold the release; a failed bundle or distribution does, and the release stays a draft. Publish it by hand with `gh release edit <tag> --draft=false --latest` once fixed.
41
+
5. The video is rendered by CI from the plan the promotion checked. A failed video, bundle or distribution holds the release, and it stays a draft. Publish it by hand with `gh release edit <tag> --draft=false --latest` once fixed.
42
42
6.`main` is back-merged into `next` automatically.
Copy file name to clipboardExpand all lines: aidd_docs/memory/deployment.md
+2-2Lines changed: 2 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -12,7 +12,7 @@ Where the project runs and how it ships: CI/CD, environments, and release.
12
12
|`cli-ci.yml`| the `cli` and `kanban` gates, jobs in the CLI bank. No `paths:` filter: a `changes` job decides in bash what has work. Mutations skip only for a verified `promote/next-to-main-*` snapshot; anything unproven keeps normal scopes |
13
13
|`validate.yml`| manifests against their schemas, plus the whole pre-commit over the whole tree |
14
14
|`codeql.yml`| code scanning |
15
-
|`promote.yml`| checks the release video covers what ships (`skip_video` bypasses), opens the `next` to `main` PR, auto-merges |
15
+
|`promote.yml`| checks the release video covers what ships, opens the `next` to `main` PR, auto-merges |
16
16
|`back-merge.yml`| folds `main` into `next` after each release |
17
17
|`dependabot-auto-merge.yml`| merges dependency PRs that pass |
18
18
|`close-finished-milestones.yml`| closes a milestone once its issues are |
@@ -55,7 +55,7 @@ flowchart TD
55
55
- The Release PR merges with `--merge --admin`: the only method `.github/rulesets/main.json` allows, so `main` never holds merged but unversioned code.
56
56
- Tags: umbrella, `cli-v<semver>`, `<plugin>-v<semver>`. `scripts/credit-release-authors.cjs` appends each author as `(@login)`, a workaround until [googleapis/release-please#2892](https://github.com/googleapis/release-please/pull/2892) ships.
57
57
- The umbrella stays a draft until every asset is attached; its publication is the event n8n listens to.
58
-
- A failed video build does not block publication, and a failed YouTube upload does not stop Discord and Skool: they post without the video link.
58
+
- A failed video build keeps the release a draft, so nothing is announced without its video. A failed YouTube upload does not stop Discord and Skool: they post without the video link.
0 commit comments