Skip to content

Merge maduranma changes: replace constructor bools with bitwise flags #4

Description

@ap0ught

Source

Fork: maduranma/ArduinoJoystickLibrary
Upstream PR: MHeironimus#244
Status: 2 commits ahead of our fork

What it adds

  • Replaces the long list of constructor boolean parameters with bitwise flags

Why we should merge it

The current constructor takes many individual bool arguments for enabling axes. That API is error-prone and hard to extend. Bitwise flags are cleaner, easier to document, and scale better as more axes/features are added. This refactor also makes it simpler to combine with other feature forks.

Risks to review

Next step

Compare maduranma's flag design with Zenilogix-Carl's and choose the more maintainable one.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions