Skip to content

[rust] Dedup KV value decode between lookup and batch scanner #573

Description

@fresh-borzoni

Search before asking

  • I searched in the issues and found nothing similar.

Description

LookupResult::to_record_batch and the limit scanner's KV decode do the same thing — [schema_id|value] -> FixedSchemaDecoder -> RecordBatch - with separate decoder caches and a duplicated read_schema_id. Extract one shared helper, the future snapshot scanner will want it too.

Touches the lookup hot path, so do it carefully on its own.

Willingness to contribute

  • I'm willing to submit a PR!

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions