feat: wire observability client to harness and evals by nborges-aws · Pull Request #2182 · aws/agentcore-cli

nborges-aws · 2026-09-03T16:12:05Z

Description

Extend shared observability abstraction to Batch Evaluation and Harness. Plus, add endpoint qualifier support to Runtime observability commands.

adds log stream reader to the shared CloudWatch client using GetLogEvents
moves CloudWatch logic hosted in batch eval stream (e.g. pagination, normalization) to the shared CloudWatch client
resolves Harness resources to their underlying Runtime IDs for observability
reuse Harness runtime resolution in existing Eval agent resolution
adds harness logs and harness traces list/get functionality
adds optional --qualifier flag to Runtime and Harness (falls back to default endpoint)
updates shared trace output handling and test coverage for CloudWatch, Eval, Harness, and Runtime wiring

Type of Change

Testing

How have you tested the change?

bun run test (2809 pass, 0 fail)
I ran npm run test:unit and npm run test:integ
I ran npm run typecheck
I ran npm run lint
If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots

_{Stack created with GitHub Stacks CLI • Give Feedback 💬}

codecov-commenter · 2026-09-03T16:20:36Z

Codecov Report

❌ Patch coverage is 85.08065% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.97%. Comparing base (3fcf406) to head (cadd0ae).

Files with missing lines	Patch %	Lines
src/handlers/harness/logs/index.tsx	44.11%	19 Missing ⚠️
src/handlers/harness/traces/get/index.tsx	65.38%	9 Missing ⚠️
src/handlers/harness/traces/list/index.tsx	62.50%	9 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##           refactor    #2182      +/-   ##
============================================
- Coverage     97.05%   96.97%   -0.09%     
============================================
  Files           555      559       +4     
  Lines         38386    38581     +195     
============================================
+ Hits          37254    37412     +158     
- Misses         1132     1169      +37

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

agentcore-devx-automation · 2026-09-04T16:51:42Z

Claude Security Review: no high-confidence findings. (run)

jariy17

Looks good!

Hweinstock

few questions, mostly looks good.

Hweinstock · 2026-09-04T17:25:08Z

-  if (config.output) return resolve(cwd, config.output);
-  return resolve(cwd, `${config.traceId}.json`);
-}
+export { resolveTraceOutputPath } from "../../observability/traceOutputPath";


whats the purpose of re-exporting here? Could we migrate consumers to the new path?

Hweinstock · 2026-09-04T17:26:42Z

+    flags: harnessFlags,
+    read: async (ctx, flags, query, signal) => {
+      const options = coreOptsFromCtx(ctx);
+      const runtime = await core.harness.resolveRuntime(flags.id, options, signal);


very clean and simple!

Hweinstock · 2026-09-04T17:29:20Z

+  });
+});
+
+describe("HarnessClient.resolveRuntime", () => {


should we be using the fixtures here?

Hweinstock · 2026-09-04T17:37:28Z

    private readonly now: () => number = () => Date.now(),
-  ) {}
+  ) {
+    this.cloudWatch = new CloudWatchClient(clients);


is there a reason we don't instantiate this here

agentcore-cli/src/core/index.tsx

Line 116 in 23e3d01

this.observability = new ObservabilityClient(this, {

, and inject it?

If a future client also wants to consume the CloudWatchClient, we would end up with two instances of the class, which I don't think we want.

agentcore-devx-automation · 2026-09-04T18:25:49Z

Claude Security Review: no high-confidence findings. (run)

agentcore-devx-automation · 2026-09-04T18:28:27Z

Claude Security Review: no high-confidence findings. (run)

github-actions Bot added the size/xl PR size: XL label Sep 3, 2026

agentcore-devx-automation Bot added the agentcore-harness-reviewing AgentCore Harness review in progress label Sep 3, 2026

nborges-aws force-pushed the harness-and-eval-wiring branch from 648c527 to 7c4f499 Compare September 3, 2026 16:16

github-actions Bot added size/l PR size: L and removed size/xl PR size: XL labels Sep 3, 2026

agentcore-devx-automation Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Sep 3, 2026