fix(cli): clean up project creation UX - #2195
Merged
Merged
Conversation
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Contributor
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
Focused UX cleanup. I checked:
--defaultsis fully removed fromsrc/handlers/project/create/index.tsand the ignore branch in the dispatch guard is gone; no other handler-side references remain. The regression test inproject.test.tsasserts Commander now rejects the flag as unknown, which is the desired breaking behavior.c.addHelpCommand(false)insrc/router/router.tsxis the right Commander API to suppress the auto-generatedhelp [command]subcommand, and it's covered by a new router test that exercises both a group and a nested group, plus asserts--helpstill works. Applying it unconditionally to every compiled command is safe — Commander only materializes the help subcommand for commands with children.- Removing the
filter((name) => name !== "help")inproject.screen.test.tsxis consistent with the new behavior; the menu now naturally sees only real subcommands. - The streamed-progress test race is properly fixed with the
beforeFirstStepgate sowaitForText("Creating DemoApp…")can reliably observe the pre-step spinner before the first yield. - Text/glyph updates (
Creating,✓ Project created in) are mirrored in every affected test.
No blocking issues. This is a cleanup, so no new telemetry surface is expected.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2195 +/- ##
============================================
- Coverage 97.08% 97.08% -0.01%
============================================
Files 544 544
Lines 37768 37764 -4
============================================
- Hits 36666 36662 -4
Misses 1102 1102 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
AlexanderRichey
approved these changes
Sep 3, 2026
aidandaly24
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing