Skip to content

fix(cli): clean up project creation UX - #2195

Merged
notgitika merged 4 commits into
aws:refactorfrom
notgitika:fix/project-create-ux-nits
Sep 3, 2026
Merged

fix(cli): clean up project creation UX#2195
notgitika merged 4 commits into
aws:refactorfrom
notgitika:fix/project-create-ux-nits

Conversation

@notgitika

@notgitika notgitika commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • lowercase the project create progress and success messages and use the shared checkmark glyph
  • remove the redundant --defaults option from project create
  • remove generated help subcommands from command groups while preserving --help

Testing

  • bun test (2,849 tests)
  • bun run typecheck
  • bun run lint:check
  • bun run format:check
  • bun run build

@github-actions github-actions Bot added the size/s PR size: S label Sep 3, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added agentcore-harness-reviewing AgentCore Harness review in progress claude-security-reviewing Claude Code /security-review in progress labels Sep 3, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Sep 3, 2026

@agentcore-devx-automation agentcore-devx-automation Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Looks good

Focused UX cleanup. I checked:

  • --defaults is fully removed from src/handlers/project/create/index.ts and the ignore branch in the dispatch guard is gone; no other handler-side references remain. The regression test in project.test.ts asserts Commander now rejects the flag as unknown, which is the desired breaking behavior.
  • c.addHelpCommand(false) in src/router/router.tsx is the right Commander API to suppress the auto-generated help [command] subcommand, and it's covered by a new router test that exercises both a group and a nested group, plus asserts --help still works. Applying it unconditionally to every compiled command is safe — Commander only materializes the help subcommand for commands with children.
  • Removing the filter((name) => name !== "help") in project.screen.test.tsx is consistent with the new behavior; the menu now naturally sees only real subcommands.
  • The streamed-progress test race is properly fixed with the beforeFirstStep gate so waitForText("Creating DemoApp…") can reliably observe the pre-step spinner before the first yield.
  • Text/glyph updates (Creating, ✓ Project created in) are mirrored in every affected test.

No blocking issues. This is a cleanup, so no new telemetry surface is expected.

@agentcore-devx-automation agentcore-devx-automation Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Sep 3, 2026
@codecov-commenter

codecov-commenter commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.08%. Comparing base (c796be3) to head (fa05d3d).

Additional details and impacted files
@@             Coverage Diff              @@
##           refactor    #2195      +/-   ##
============================================
- Coverage     97.08%   97.08%   -0.01%     
============================================
  Files           544      544              
  Lines         37768    37764       -4     
============================================
- Hits          36666    36662       -4     
  Misses         1102     1102              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added size/s PR size: S and removed size/s PR size: S labels Sep 3, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label Sep 3, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Sep 3, 2026
@github-actions github-actions Bot added size/s PR size: S and removed size/s PR size: S labels Sep 3, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label Sep 3, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Sep 3, 2026
@github-actions github-actions Bot added size/s PR size: S and removed size/s PR size: S labels Sep 3, 2026
@notgitika
notgitika merged commit 6a376c1 into aws:refactor Sep 3, 2026
23 of 26 checks passed
@notgitika
notgitika deleted the fix/project-create-ux-nits branch September 3, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s PR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants