Feature summary
The package-lock.json file in repos is meant to be committed, so it should also be ingested.
Problem / motivation
For JS/TS projects, package-lock.json is an important file which locks dependencies.
According to the official npm docs, it shouldn't be ignored: "This file is intended to be committed into source repositories [...]"
I just came across this hiccup with gitingest after the coding agent I was using complained that package-lock.json was missing from the text digest.
Proposed solution
It seems that the issue could be solved if this line was removed:
Alternatives considered
I'm using the Web UI of gitingest and I tried adding "package-lock.json" to the "Include" field, but that just resulted in the json file being the only file included. I probably should've used some pattern, but then I just copied the file as a whole and added it to my coding agent's context directly.
Which interface would this affect?
Web UI
How important is this to you?
Important
Would you like to work on this feature yourself?
Yes, I'd like to implement it
Would you need support from the maintainers (if you're implementing it yourself)?
Not sure yet
Additional context, screenshots, or examples
Thanks for creating and maintaining this useful project!
Feature summary
The
package-lock.jsonfile in repos is meant to be committed, so it should also be ingested.Problem / motivation
For JS/TS projects,
package-lock.jsonis an important file which locks dependencies.According to the official npm docs, it shouldn't be ignored: "This file is intended to be committed into source repositories [...]"
I just came across this hiccup with gitingest after the coding agent I was using complained that
package-lock.jsonwas missing from the text digest.Proposed solution
It seems that the issue could be solved if this line was removed:
gitingest/src/gitingest/utils/ignore_patterns.py
Line 25 in 4e259a0
Alternatives considered
I'm using the Web UI of gitingest and I tried adding "package-lock.json" to the "Include" field, but that just resulted in the json file being the only file included. I probably should've used some pattern, but then I just copied the file as a whole and added it to my coding agent's context directly.
Which interface would this affect?
Web UI
How important is this to you?
Important
Would you like to work on this feature yourself?
Yes, I'd like to implement it
Would you need support from the maintainers (if you're implementing it yourself)?
Not sure yet
Additional context, screenshots, or examples
Thanks for creating and maintaining this useful project!