Repository navigation
build: stop registering unused Go toolchains and loading rules_py's platform package (#9203) - #9303
Closed
TrapsterDK wants to merge 2 commits into
Closed
TrapsterDK wants to merge 2 commits into
TrapsterDK wants to merge 2 commits into
Conversation
…latform package (#9203) rules_go: when the root module declares its own Go SDKs, toolchains from other modules' go_sdk tags are no longer registered. Their SDK repos are still created, so their use_repo names keep working. @go_toolchains drops from 54 declare_bazel_toolchains calls to 6. rules_py: the platform_libc and platform_version string_flags move to //uv/private/constraints/platform/flags. The old labels stay as aliases. The interpreter toolchains' config_settings now point at the small package, so toolchain resolution no longer loads //uv/private/constraints/platform. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xut2hzpb4qWNZKpDCrwUz7
Taken from the merged artifact of lock-refresh run 42374657201, whose push was refused. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xut2hzpb4qWNZKpDCrwUz7
Collaborator
Author
|
Dropped: it is about 16s slower on windows_x86_64 over two evidence pairs, but 4s faster on linux_x86_64. The numbers are on #9203 and #8912. 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #9203. This is a speed experiment. It is kept only if the evidence pairs show at least 2s saved.
rules_go (
patches/rules_go/root_sdks_only.patch): when the root module declares Go SDKs withdownload,from_file,wraporhost, toolchains from other modules'go_sdktags are no longer registered. Their SDK repos are still created, souse_repokeeps working.@go_toolchainsdrops from 54declare_bazel_toolchainscalls to 6. Before this change, the 48 extra toolchains were registered after ours and never picked. Upstream: bazel-contrib/rules_go#4779.rules_py (
patches/rules_py/platform_flags_package.patch):platform_libcandplatform_versionmove to//uv/private/constraints/platform/flags, and the old labels becomealiases. The interpreter toolchainconfig_settings,defs.bzl, the PEP 517 frontend transition andpep517_native_whlnow use the new labels. Toolchain resolution no longer loads//uv/private/constraints/platform. Upstream: aspect-build/rules_py#1675.Local checks (linux_x86_64)
bazel test //cli/process/... //go/tools/modfmt:modfmt_test //python/tests/fixtures/hello:hello_test: 4 tests pass.cquery deps(//python/tests/fixtures/hello:hello_test):@python_3_12_x86_64_unknown_linux_gnu;--@rules_py//uv/private/constraints/platform:platform_libc=musl(the alias) or with the new.../flags:platform_libc=musl, it pickspython_3_12_x86_64_unknown_linux_musl.--profileofbuild --nobuild //cli/process/...on a fresh server:@@rules_py+//uv/private/constraints/platform: no longer loaded (only.../flags, 1 ms);@@rules_go++go_sdk+go_toolchains//package creation: 33 ms, compared with 123 ms for@@llvm+//toolchainin the same run.*_consumer_testtargets were not run.Remaining
MODULE.bazel.lockwith lock-refresh.OVERRIDESrules_py patch and a rules_go row incli/adopt/src/overrides.rs, update thepatches/README.mdrows and runtools/dx init --applyinfamilies/*.🤖 Generated with Claude Code
https://claude.ai/code/session_01Xut2hzpb4qWNZKpDCrwUz7