[TrapsterDK]

Main at 681c1fa fails during loading on linux_x86_64 and linux_arm64. The PHP 8.5.12 gnu-bulk download has a checksum mismatch (evidence run 42384304291).

Cause: dl.static-php.dev rebuilt php-8.5.12-cli-linux-{x86_64,aarch64}.tar.gz in place on 2026-11-07 (07:29 and 07:33 UTC). The version string is unchanged. The pinned sha256 values were correct for the old builds.

Fix: update the two digests in php/toolchain/pins.bzl:

• x86_64: 3c932354edf5b49d70815fb3e6df3c3d30d3a17ecdd7e89778e31aa870c43897
• aarch64: ed2ae18b2c278f6559ff902f9126a59509f56ef5600ba7f34bd69cca2b0ae944

Both digests match the official .sha256 files that upstream publishes next to each archive, and my local downloads. The rebuilt x86_64 binary reports PHP 8.5.12 (cli) (built: Nov 7 2026 07:31:36). Upstream has no immutable URL for these builds, so I used the refreshed checksum. #9283 handled macOS the same way.

Verification (local):

• bazel fetch of @@+php+dx_php_linux_amd64 and @@+php+dx_php_linux_arm64 succeeds.
• bazel build //php/tools:phpcs //php/tools:phpstan succeeds.
• bazel test //php/toolchain:metadata //php/toolchain:version_test passes.
• Regenerating the lockfile (bazel mod deps --lockfile_mode=update) produced no diff.

Evidence: run 42384867184 (//quality:all, build, linux_x86_64): PENDING

🤖 Generated with Claude Code

https://claude.ai/code/session_01Xut2hzpb4qWNZKpDCrwUz7

[TrapsterDK]

Review: changes requested

The marker changes look correct. Every dropped # keep is on a rule that has data or env, so staleRules/hasHandwrittenAttr (gazelle/rust/lang_generate.go:886,911) never deletes it. The two exceptions also check out: support_matrix/support_matrix_test and tiers/tiers_test match what source-only generation produces (inline #[cfg(test)], same srcs, imports resolve). Each "would delete it" reason sits on a rule with none of those attrs. No duplicated blocks. No lines that main deleted come back. The only file that main changed since the merge base is quality/BUILD.bazel, and that change doesn't overlap this diff.

Findings:

1. The PR description belongs to another PR: it describes the PHP 8.5.12 checksum fix. It needs the before and after # keep counts that rust: # keep markers and gazelle:resolve directives that Gazelle can infer are removed #9168 step 3 asks for (from my count, 110 -> 52 under cli/libs/quality/tools/deploy/generation).
2. BUILD.bazel:10-62: rust: # keep markers and gazelle:resolve directives that Gazelle can infer are removed #9168 step 2 (delete the gazelle:resolve rust X //pkg:X lines for indexed rust_library targets) is not done, but the title says "closes rust: # keep markers and gazelle:resolve directives that Gazelle can infer are removed #9168". Either do it or change the title to "part of".
3. quality/tests/fixtures/generated_policy/BUILD.bazel:2: # Hand-written fixture input. contradicts line 3 (# Generated by dx from dx.toml; dx generate rewrites this file.). That also puts two # lines where AGENTS.md allows one.
4. cc/context/BUILD.bazel:155,188: the PR edits this file but leaves two bare # keep markers. Both rules have data/env and sit under tests/headless_lsp/, which source-only generation does not discover. Drop them or give them a reason.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Xut2hzpb4qWNZKpDCrwUz7