Skip to content

[vendored-sync] dotnet-test-wire-contract-constants: drift detected (#0) #55695

Description

@github-actions

Automated drift report for vendored file src/Cli/dotnet/Commands/Test/CliConstants.cs.

Source

Drift

  • Baseline blob SHA: 8e11c4ba1b8472a4d28178f28ef088c0c0948580
  • Current blob SHA: 6e600501f588911e8be1166394a25f03f47a2fe7
  • Baseline ref SHA : f935d2d3f9ce1ab831a361041b0ceaf92ff73363
  • Current ref SHA : fa72bc4aabf1f67d55c33c97bf29d02799b14d71

Links

Upstream-only diff

--- src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/IPC/Constants.cs@8e11c4b
+++ src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/IPC/Constants.cs@6e60050
@@ -95,6 +95,12 @@
 
     // Semicolon-separated lowercase file extensions used as a compatibility fallback for untagged artifacts.
     internal const byte SupportedPostProcessorExtensionsLegacy = 15;
+
+    // Subset of SupportedPostProcessorKinds that can process artifacts observed before a run was truncated.
+    internal const byte SupportedTruncatedRunPostProcessorKinds = 16;
+
+    // Subset of SupportedPostProcessorExtensionsLegacy that can process artifacts observed before a run was truncated.
+    internal const byte SupportedTruncatedRunPostProcessorExtensionsLegacy = 17;
 }
 
 [Embedded]

Local adaptation notes

Handshake/session/state string constants for the 'dotnet test' named-pipe protocol. Upstream lives in testfx IPC/Constants.cs; the SDK inlines the same constants into CliConstants.cs (TestStates, SessionEventTypes, HandshakeMessagePropertyNames, HandshakeMessageExecutionModes, HandshakeMessageHostTypes, ProtocolConstants). Watch the upstream file for added/changed wire constants. Reconciled at f935d2d3: the upstream additions since the previous baseline (SupportedPostProcessorKinds/SupportedPostProcessorExtensionsLegacy, the ArtifactPostProcessor host type and the 'tool' execution mode) are already mirrored in CliConstants.cs, so this was a baseline bump only. Intentional divergences: the SDK does not mirror TestStates.InProgress or HandshakeMessagePropertyNames.OrchestratorFeature (it consumes neither), and ProtocolConstants.SupportedVersions deliberately stops at 1.3.0 because the SDK does not implement the 1.4.0 reverse server-control channel.

How to reconcile

  1. Review the upstream changes and decide whether they should be ported.
  2. Port the relevant changes to src/Cli/dotnet/Commands/Test/CliConstants.cs.
  3. Update eng/vendored-files.json entry dotnet-test-wire-contract-constants (source index 0):
    • bump baseline_ref_sha to the new upstream ref SHA,
    • bump baseline_blob_sha to the new upstream blob SHA.
  4. Close this issue once the reconciliation PR is merged.

If no port is needed (e.g. whitespace-only upstream change), still bump the baseline SHAs to silence future runs.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-vendored-syncDrift detected between a vendored source file and its upstream copyuntriagedRequest triage from a team member

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions