Skip to content

Commit a4366bb

Browse files
Complete the bundled space-group database (#187)
* Add space-group-database ADR suggestion * Add space-group-database implementation plan * Add cctbx-based space-group table extraction * Add multi-source cross-check and disagreement report * Generate initial space-group disagreement report * Localize space-group curation artifacts * Move crysview demo to subdirectory * Add curated space-group overrides * Generate complete space_groups.json.gz with recorded provenance * Load space groups from JSON and drop restricted unpickler * Reach Phase 1 review gate * Cover public space-group coordinate aliases * Add space-group database ADR index row * Add Phase 2 space-group database tests and packaging check * Apply pixi run fix auto-fixes * Alias runtime coordinate codes in space-group database * Apply prettier formatting to space-group-database ADR * Make packaging check inspect the wheel directly * Unify Plotly tooltip styling and fix white Bragg hover * Guard optional IPython import in table backend base * Pin space-group record count in tests and wheel check * Update Plotly hover test and fix overlong comment * Update tutorial links to latest docs * Add Wyckoff letter detection ADR
1 parent 2d46651 commit a4366bb

23 files changed

Lines changed: 3024 additions & 239 deletions

File tree

β€Ždocs/dev/adrs/accepted/crysview-structure-visualization.mdβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ parameters a refinement is adjusting.
2222

2323
A working prototype establishes the target experience and the data it
2424
needs. It lives at
25-
[`crysview-threejs-demo.html`](crysview-threejs-demo.html) and
26-
demonstrates, against a non-orthogonal unit cell:
25+
[`crysview-threejs-demo.html`](crysview-structure-visualization/crysview-threejs-demo.html)
26+
and demonstrates, against a non-orthogonal unit cell:
2727

2828
- atoms as spheres with element radius and colour;
2929
- anisotropic ADP ellipsoids (semi-axis lengths plus orientation);
File renamed without changes.

β€Ždocs/dev/adrs/index.mdβ€Ž

Lines changed: 43 additions & 40 deletions
Large diffs are not rendered by default.

β€Ždocs/dev/adrs/suggestions/background-auto-estimate.mdβ€Ž

Lines changed: 532 additions & 0 deletions
Large diffs are not rendered by default.

β€Ždocs/dev/adrs/suggestions/plotting-docs-performance.mdβ€Ž

Lines changed: 434 additions & 0 deletions
Large diffs are not rendered by default.

β€Ždocs/dev/adrs/suggestions/space-group-database.mdβ€Ž

Lines changed: 515 additions & 0 deletions
Large diffs are not rendered by default.
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
# Space-group database curated overrides.
2+
#
3+
# Initial minimal seed decision, 2026-06-02:
4+
# Use the ADR source priority without manual row-level overrides for now:
5+
# cryspy wyckoff.dat for Wyckoff-facing values, cctbx/sgtbx for
6+
# setting-level metadata, and RASPA/Avogadro/SgInfo/gemmi as cross-checks.
7+
#
8+
# Flagged rows remain visible in tmp/space-groups/extracted-comparison/
9+
# for future verification against International Tables Vol A, Bilbao
10+
# Crystallographic Server, and ISODISTORT.
11+
[]

β€Ždocs/dev/adrs/suggestions/wyckoff-letter-detection.mdβ€Ž

Lines changed: 502 additions & 0 deletions
Large diffs are not rendered by default.

β€Ždocs/dev/package-structure/full.mdβ€Ž

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,6 @@
263263
β”‚ β”œβ”€β”€ πŸ“„ __init__.py
264264
β”‚ β”œβ”€β”€ πŸ“„ crystallography.py
265265
β”‚ └── πŸ“„ space_groups.py
266-
β”‚ └── 🏷️ class _RestrictedUnpickler
267266
β”œβ”€β”€ πŸ“ datablocks
268267
β”‚ β”œβ”€β”€ πŸ“ experiment
269268
β”‚ β”‚ β”œβ”€β”€ πŸ“ categories

β€Ždocs/dev/plans/background-auto-estimate.mdβ€Ž

Lines changed: 276 additions & 0 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
Β (0)