Skip to content

Commit 7103077

Browse files
authored
turn on bulk sync by default (#115)
* turn on bulk sync by default Signed-off-by: Eric Pickard <piceri@github.com> * remove experimental comment Signed-off-by: Eric Pickard <piceri@github.com> --------- Signed-off-by: Eric Pickard <piceri@github.com>
1 parent 5d57fcd commit 7103077

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ Two modes of authentication are supported:
7272
| `LOGICAL_ENVIRONMENT` | Logical environment name | (required) |
7373
| `PHYSICAL_ENVIRONMENT` | Physical environment name | `""` |
7474
| `CLUSTER` | Cluster name | (required) |
75+
| `BULK_CLUSTER_SYNC` | Bulk-sync cluster state at startup | `true` |
7576
| `API_TOKEN` | API authentication token | `""` |
7677
| `GH_APP_ID` | GitHub App ID | `""` |
7778
| `GH_INSTALL_ID` | GitHub App installation ID | `""` |

cmd/deployment-tracker/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ func main() {
9696
GHAppPrivateKey: ghAppPrivateKey,
9797
GHAppPrivateKeyPath: getEnvOrDefault("GH_APP_PRIV_KEY_PATH", ""),
9898
Organization: os.Getenv("GITHUB_ORG"),
99-
BulkClusterSync: strings.EqualFold(getEnvOrDefault("BULK_CLUSTER_SYNC", "false"), "true"),
99+
BulkClusterSync: strings.EqualFold(getEnvOrDefault("BULK_CLUSTER_SYNC", "true"), "true"),
100100
}
101101

102102
if len(cntrlCfg.GHAppPrivateKey) > 0 && cntrlCfg.GHAppPrivateKeyPath != "" {

internal/controller/config.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,7 @@ type Config struct {
3131
Organization string
3232
// BulkClusterSync enables the async cluster job endpoint for startup
3333
// state sync. When false, startup sync is skipped and only individual
34-
// PostOne calls are used. **Note: this is experimental and not yet available
35-
// for public use.**
34+
// PostOne calls are used.
3635
BulkClusterSync bool
3736
}
3837

0 commit comments

Comments
 (0)