Skip to content

Map alternate scope names in addScopes #599

Description

@stuartmorgan-g

Describe the bug
When calling addScopes, the check against the existing granted scopes doesn't normalize the names. If the core scopes are passed in using their short names (email, openid, profile), the SDK will prompt unnecessarily, because the granted scopes appear to use the v2 names.

Obviously this can be easily worked around from the client side by not making that call in the first place, but it creates some unexpected complexity in the Flutter wrapper (see flutter/flutter#184872), which has to bridge across the iOS, Android, and Web sign in APIs (which are all quite different). We can work around it at the wrapper level, but it would be nice if the SDK handled this name mismatch internally.

To Reproduce
Steps to reproduce the behavior:

  1. Sign in.
  2. Call addScopes:... with [@"email", @"openid", @"profile"] as the scopes.
  3. See a user prompt.

Expected behavior
Receive kGIDSignInErrorCodeScopesAlreadyGranted, since AFAICT signing in grants those scopes automatically, but under different names.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions