Skip to content

Review checklist should account for providers without signature verification #26

Description

@leggetter

Context

During testing of the CLI adapter system with Postmark webhooks, the automated review flagged a "critical" issue that wasn't actually a problem:

The documentation correctly states that Postmark does NOT use signature verification, which aligns with the official documentation. However, the review checklist's focus on signature verification is misleading for this provider.

Problem

The review prompt in scripts/skill-generator/prompts/review-skill.md focuses heavily on signature verification as a critical check. For providers like Postmark that use URL-based authentication (token in query param or basic auth) instead of signature verification, this creates misleading review feedback.

Suggested Fix

Update the review checklist to:

  1. Recognize that some providers don't use signature verification
  2. Check that the skill correctly documents the provider's actual authentication method
  3. Only flag missing signature verification as critical if the provider actually uses it

Providers Without Signature Verification

  • Postmark - Uses URL-based token authentication or basic auth
  • (Others may exist)

Related

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions