Repository navigation
chore: move to @chelonia/lib 2.0.0 and chel 3.4.1 - #7
Conversation
|
/review AI review started. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Advanced AI Review
Click to expand reviewCode ReviewBase: This PR bumps
One minor gap found, otherwise no issues. 1. ⚪ Signup status mapping misses 409, the one status with an existing message
The new status handling in // The publish error carries the HTTP status on `cause`.
if (e instanceof ChelErrorUnexpectedHttpResponseCode) {
if (e.cause === 403) throw new AuthError('Signups are disabled on this server.')
if (e.cause === 409) throw new AuthError('That username is already taken.')
if (e.cause === 429) {
throw new AuthError('Too many signups from this network. Try again in a while.')
}
}Low importance: the window is a narrow race and the fallback message is still Review generated using |
corrideat
left a comment
There was a problem hiding this comment.
LGTM. See comment about removing a section that's probably redundant from the README.
|
@taoeffect need your review. |
taoeffect
left a comment
There was a problem hiding this comment.
Looks nice! Great job @akhileshthite !
Closes #4. Based on #6.
Moves to
@chelonia/lib2.0.0 and chel 3.4.1, and removes the workaroundsthey fix:
nameToContractID.too many from this network.
randomUUIDfallback and theLIGHTWEIGHT_CLIENTsetting are gone, thelibrary handles both now.
DENO_SQLITE_PATHworkaround and its CIstep are gone.
todomvc/identityinstead of borrowing GroupIncome's
gi.contracts/identity, so the contract version is 0.3.0. Olderlocal accounts still log in but their lists do not show. To start fresh,
delete
data/,contracts/andchelonia.json.Three new e2e tests: the two signup messages, and making a list after a
reload, which breaks if the app ever stops running as a lightweight client.
Two TODOs from #4 are left. Neither blocks anything, and both are listed in
AGENTS.md:
USERNAME_REGEXis a copy of chel's private name rule, so signup can say aname is invalid before sending anything. It matches chel today; apps just
cannot import the rule yet.
tidy-up, not a workaround.
AI usage: Claude Opus 5.5 Max
Self review: Approved