Repository navigation
O3-5760: Return null rather than NaN for the average wait time - #120
Merged
NethmiRodrigo merged 2 commits intoJul 31, 2026
Merged
Conversation
3 tasks done
NethmiRodrigo
left a comment
NethmiRodrigo
left a comment
Contributor
There was a problem hiding this comment.
Thanks @UjjawalPrabhat! Just one minor thing
|
NethmiRodrigo
approved these changes
Jul 31, 2026
NethmiRodrigo
left a comment
NethmiRodrigo
left a comment
Contributor
There was a problem hiding this comment.
Thanks @UjjawalPrabhat!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Came up while reviewing openmrs-esm-patient-management#2615, where the Service Queues dashboard rendered "NaN mins".
QueueUtils.computeAverageWaitTimeInMinutesonly guards against an empty entry list, but it averages over entries that have both astartedAtand anendedAt. A non-empty list where nothing has ended leaves the denominator at zero, soqueue-entry-metrics?metric=averageWaitTimereturns{"averageWaitTime":"NaN"}.Returns
nullinstead when there is no completed wait to average.Related Issue
O3-5760
Other
Related PR here.