Bump Go toolchain to 1.25.3 to fix covdata unit test failure (#2290)

* Bump Go toolchain to 1.25.3 to fix covdata unit test failure

Go 1.25.0 has a bug where packages with no test files cause
"go: no such tool covdata" errors when run with -coverprofile,
resulting in a non-zero exit code from go test. This was fixed
in later patch releases. Bumping the toolchain directive ensures
CI downloads go1.25.3 instead of using the broken go1.25.0.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Follow oadp-dev pattern: set go 1.25.0 directive and update submit-coverage

The previous toolchain bump alone did not fix the covdata error.
Following the oadp-dev branch pattern:
- Set go directive to 1.25.0 and remove the toolchain line
- Simplify submit-coverage target with --nonZero flag
- Add SED = gsed for macOS compatibility

The CI config in openshift/release will also need updating to set
GOTOOLCHAIN=go1.25.0+auto (matching oadp-dev's CI config).

Co-authored-by: Cursor <cursoragent@cursor.com>

* bump go to 1.26

Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>

---------

Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

Author: weshayutin

Dockerfile

@@ -1,5 +1,5 @@
 # Build the manager binary
-FROM quay.io/konveyor/builder:ubi9-v1.23 AS builder
+FROM quay.io/konveyor/builder:ubi9-v1.26 AS builder
 
 WORKDIR /go/src/github.com/openshift/oadp-operator
 # Copy the Go Modules manifests

Makefile

@@ -275,20 +275,14 @@ else
     endif
     ifeq ($(UNAME_S),Darwin)
         OS_String = macos
+		SED = gsed
     endif
 endif
 submit-coverage:
 	curl -Os https://uploader.codecov.io/latest/$(OS_String)/codecov
 	chmod +x codecov
-	./codecov > tmp.results 2> tmp.err
-	cat tmp.results || echo "tmp.results not found"
-	cat tmp.err || echo "tmp.err not found"
-	@echo $$(cat tmp.results | grep 'resultURL' -c)
-	@echo $$(cat tmp.err | grep 'please specify sha and slug manually' -c)
-	if [ $$(cat tmp.err | grep 'please specify sha and slug manually' -c) == 1 ]; then \
-		echo "specifying sha and slug manually" && ./codecov -C $(shell git rev-parse HEAD) -r openshift/oadp-operator; \
-	fi
-	rm -f codecov tmp.*
+	./codecov -C $(shell git rev-parse HEAD) -r openshift/oadp-operator --nonZero
+	rm -f codecov
 
 # go-install-tool will 'go install' any package $2 and install it to $1.
 PROJECT_DIR := $(shell dirname $(abspath $(lastword $(MAKEFILE_LIST))))

go.mod

@@ -1,8 +1,6 @@
 module github.com/openshift/oadp-operator
 
-go 1.23.0
-
-toolchain go1.23.6
+go 1.25.0
 
 require (
 	github.com/aws/aws-sdk-go v1.44.253

konflux.Dockerfile

@@ -1,4 +1,4 @@
-FROM brew.registry.redhat.io/rh-osbs/openshift-golang-builder:rhel_9_golang_1.24 AS builder
+FROM brew.registry.redhat.io/rh-osbs/openshift-golang-builder:rhel_9_golang_1.26 AS builder
 COPY . /workspace
 WORKDIR /workspace
 ENV GOEXPERIMENT strictfipsruntime