Skip to content

simplify #[cfg(feature ... shenanigans in verifier-cli #420

Description

@flihp

We've recently moved the hiffy interface to verfivier-cli behind a cargo feature. We have reasonable defaults set, and everything builds as it should (I think), but doing so required a lot of #[cfg(feature ... stuff. The end result is unfortunately less readable / comprehensible code. Everything's a trade off and since this currently works I'm not proposing any immediate changes. Instead this issue should serve as a place to collect opinions on what, if any changes can be made to mitigate this.

The the approach that comes to mind immediately is to hard code support for at least one interface. This could be an interface to the mock / simulator of the RoT if we don't want to hard code a dependency on any of the other interfaces. AFAIK the only interface that must be behind a feature is ipcc due to linking stuff & libipcc.so.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions