Skip to content

makeRequest does not have listener for 'error' event #4

Description

@aarsilv

Request errors are ignored, which makes it hard to debug and/or for applications to handle them. Ideally you pass request errors like other errors:

panda.js - makeRequest function:

    res.addListener('error', function(err) {
        cb({error: 'requestError', message: err.message});
    });

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions