Skip to content

Missing checks and error trace lost #101

Description

@aelmizeb

Hi,

There is a missing check for the function generateJWT in the lib/Payplug/Authentication.php, at this line :

$response['httpResponse']['expires_date'] = time() + $response['httpResponse']['expires_in'];

There is no check for the ['expires_in'] index

Also the error trace is lost if you keep doing :
} catch (Exception $e) { return array(); }

You have to throw exception so it can be used

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions