From 5ad0461a1d0ba488d1725b4c32caad79078935f6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9ment=20Cailly?= Date: Thu, 30 Jul 2026 11:40:41 +0200 Subject: [PATCH] fix(hidden-question): Adding string condition handlers for hidden question type --- src/Model/QuestionType/HiddenQuestion.php | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/src/Model/QuestionType/HiddenQuestion.php b/src/Model/QuestionType/HiddenQuestion.php index e987154..620664b 100644 --- a/src/Model/QuestionType/HiddenQuestion.php +++ b/src/Model/QuestionType/HiddenQuestion.php @@ -34,6 +34,9 @@ namespace GlpiPlugin\Advancedforms\Model\QuestionType; use Glpi\Application\View\TemplateRenderer; +use Glpi\DBAL\JsonFieldInterface; +use Glpi\Form\Condition\ConditionHandler\StringConditionHandler; +use Glpi\Form\Condition\UsedAsCriteriaInterface; use Glpi\Form\Migration\FormQuestionDataConverterInterface; use Glpi\Form\Question; use Glpi\Form\QuestionType\AbstractQuestionType; @@ -46,7 +49,10 @@ * Legacy question type from the formcreator plugin * Original source: https://github.com/pluginsGLPI/formcreator/blob/2.13.10/inc/field/hiddenfield.class.php */ -final class HiddenQuestion extends AbstractQuestionType implements ConfigurableItemInterface, LegacyQuestionTypeInterface +final class HiddenQuestion extends AbstractQuestionType implements + ConfigurableItemInterface, + LegacyQuestionTypeInterface, + UsedAsCriteriaInterface { #[Override] public function getCategory(): QuestionTypeCategoryInterface @@ -150,4 +156,11 @@ public function getMapperClass(): FormQuestionDataConverterInterface { return new FormcreatorHiddenTypeMapper(); } + + #[Override] + public function getConditionHandlers( + ?JsonFieldInterface $question_config, + ): array { + return array_merge(parent::getConditionHandlers($question_config), [new StringConditionHandler()]); + } }