Repository navigation
Commit f610e42
authored
Promote Write Guard Threat Model and Review Cost Changes to Main (#3405)
## Summary
Promotes these pull requests from develop. Each carries a maintainer
decision recorded on #3391.
- [#3399](#3399): states
the write guard's threat model and documents two shapes it keeps
allowed, a quoted run-time `-C` value and an `xargs` replace string run
as a shell script (item 1).
- [#3401](#3401): lists a
pre-existing review finding in the pull request body instead of filing
an issue for it (item 2).
- [#3402](#3402): keeps
one standing handoff issue per track, edited in place each round, with a
`close` subcommand that ends a track (item 5).
- [#3400](#3400): adds a
weekly backlog and review-cost report script.
- [#3403](#3403): runs the
Copilot review once per change, at the promotion, with the attested
local pass covering a pull request into develop (item 4).
- [#3404](#3404): aligns
the remaining review rule text with the promotion-only Copilot review
(items 2 and 4).
- [#3406](#3406): fixes
the findings this promotion's first Copilot round raised on the content
above, in the `wait` note for a head no local pass covers, the
pr-review-conduct heading, and the backlog report's label line and cost
scoping.
Closes #3382
Closes #3385
## Pre-existing findings, not filed
- The [Copilot round on
4a77a1d](#3405 (review))
headline says documentation does not consistently describe current-head
Copilot refusal handling. `local_cover` in `scripts/pr_review.py`
refuses an attested head whose current Copilot round is a refusal, and
`wait` exits `41` there. The `wait` entry of the `pr_review.py`
docstring ("An attested head is covered at once.") and the
`scripts/README.md` paragraph on the defined review moments ("Where it
is attested, `wait` polls the head's checks instead.") leave that
exception out. `pr-review-conduct` Merge Gate item 2 states it ("A
refusal is not that coverage"). Both omissions are on `main` already, so
this promotion did not introduce them.
🤖 Generated with [Claude Code](https://claude.com/claude-code)41 files changed
Lines changed: 2391 additions & 1382 deletions
File tree
- .agents/skills
- agent-conduct
- drive-pr
- local-strict-review
- pr-review-conduct
- session-handoff
- unattended-handoff
- .claude-plugin/fleet-skills
- .source-digests
- skills
- agent-conduct
- drive-pr
- local-strict-review
- pr-review-conduct
- session-handoff
- unattended-handoff
- .github
- skills
- agent-conduct
- drive-pr
- local-strict-review
- pr-review-conduct
- session-handoff
- unattended-handoff
- docs
- host-setup/agent-safety
- claude
- repo-config
- scripts
- tests
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
62 | | - | |
| 62 | + | |
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
100 | | - | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
101 | 105 | | |
102 | 106 | | |
103 | 107 | | |
| |||
153 | 157 | | |
154 | 158 | | |
155 | 159 | | |
156 | | - | |
157 | | - | |
| 160 | + | |
| 161 | + | |
158 | 162 | | |
159 | 163 | | |
160 | 164 | | |
| |||
183 | 187 | | |
184 | 188 | | |
185 | 189 | | |
186 | | - | |
187 | | - | |
188 | | - | |
189 | | - | |
190 | | - | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
191 | 224 | | |
192 | 225 | | |
193 | 226 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
148 | 148 | | |
149 | 149 | | |
150 | 150 | | |
151 | | - | |
| 151 | + | |
152 | 152 | | |
153 | 153 | | |
154 | 154 | | |
| |||
0 commit comments