Skip to content

s2i-base: update nodejs version installed - #370

Merged
pkubatrh merged 1 commit into
sclorg:masterfrom
pkubatrh:update_node
Oct 7, 2026
Merged

s2i-base: update nodejs version installed#370
pkubatrh merged 1 commit into
sclorg:masterfrom
pkubatrh:update_node

Conversation

@pkubatrh

@pkubatrh pkubatrh commented Oct 7, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Updates
    • Updated the RHEL 8 base image to use Node.js 24 instead of Node.js 20.

@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 46 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d9c1f0e9-b646-407f-9438-26f24f212971
📥 Commits

Reviewing files that changed from the base of the PR and between 4a3fd1c and d5a026f.

📒 Files selected for processing (1)
  • base/Dockerfile.rhel8

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0651e025-d9f3-4b12-b880-169de50105e1
📥 Commits

Reviewing files that changed from the base of the PR and between dc62595 and 4a3fd1c.

📒 Files selected for processing (1)
  • base/Dockerfile.rhel8

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

The RHEL 8 base image changes its configured Node.js version from 20 to 24. The module enablement and version check use the updated version.

Changes

RHEL 8 Node.js version

Layer / File(s) Summary
Update configured Node.js version
base/Dockerfile.rhel8		 The configured Node.js version changes from 20 to 24. Module enablement and the version check use version 24.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 4a3fd

The RHEL 8 image is configured consistently for Node.js 24, and the inspected UBI 8 x86_64 repository exposes that stream. No actionable merge-blocking issue was identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the Node.js version update in the RHEL 8 base image.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

Pull Request validation

Failed

🔴 Failed or pending statuses:

  • CodeRabbit[pending]

🔴 Review - Missing review from a member (1 required)

Triggered by Workflow Run

@github-actions

github-actions Bot commented Oct 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Pull Request validation

Failed

🔴 Failed or pending statuses:

  • Testing Farm - Fedora - PyTest - base[pending]
  • Testing Farm - CentOS Stream 9 - core[pending]
  • Testing Farm - RHEL9 - PyTest - core[pending]
  • Testing Farm - CentOS Stream 9 - base[pending]
  • Testing Farm - RHEL8 - core[pending]
  • Testing Farm - RHEL8 - PyTest - core[pending]
  • Testing Farm - RHEL8 - PyTest - base[pending]
  • Testing Farm - RHEL10 - PyTest - core[pending]
  • Testing Farm - RHEL10 - base[pending]
  • Testing Farm - CentOS Stream 9 - PyTest - base[pending]
  • Testing Farm - RHEL8 - base[pending]
  • Testing Farm - RHEL10 - core[pending]
  • Testing Farm - RHEL9 - PyTest - base[pending]
  • Testing Farm - RHEL9 - base[pending]
  • Testing Farm - RHEL10 - PyTest - base[pending]
  • Testing Farm - RHEL9 - core[pending]
  • Testing Farm - CentOS Stream 9 - PyTest - core[pending]

🔴 Review - Missing review from a member (1 required)

Triggered by Workflow Run

@pkubatrh

pkubatrh commented Oct 7, 2026

Copy link
Copy Markdown
Member Author

[test-all]

@pkubatrh
s2i-base: update nodejs version installed
d5a026f 
The current version 20 is no longer supported by Red Hat.
Switching to Node 24 that has support until 2028.
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

Testing Farm results

namecomposearchstatusstarted (UTC)timelogs
Fedora - baseFedora-latestx86_64✅ passed07.10.2026 07:55:3210min 43stest pipeline

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

Testing Farm results

namecomposearchstatusstarted (UTC)timelogs
CentOS Stream 10 - baseCentOS-Stream-10x86_64✅ passed07.10.2026 07:55:3311min 30stest pipeline

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

Testing Farm results

namecomposearchstatusstarted (UTC)timelogs
CentOS Stream 10 - PyTest - baseCentOS-Stream-10x86_64✅ passed07.10.2026 07:55:3111min 15stest pipeline

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

Testing Farm results

namecomposearchstatusstarted (UTC)timelogs
CentOS Stream 10 - coreCentOS-Stream-10x86_64✅ passed07.10.2026 07:55:3210min 17stest pipeline

@github-actions

github-actions Bot commented Oct 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Testing Farm results

namecomposearchstatusstarted (UTC)timelogs
Fedora - PyTest - coreFedora-latestx86_64✅ passed07.10.2026 08:08:3511min 58stest pipeline
Fedora - coreFedora-latestx86_64✅ passed07.10.2026 08:09:1211min 49stest pipeline
CentOS Stream 10 - PyTest - coreCentOS-Stream-10x86_64✅ passed07.10.2026 08:08:3511min 34stest pipeline
Fedora - PyTest - baseFedora-latestx86_64✅ passed07.10.2026 08:08:3512min 18stest pipeline
CentOS Stream 10 - PyTest - baseCentOS-Stream-10x86_64✅ passed07.10.2026 08:08:3410min 32stest pipeline
CentOS Stream 10 - baseCentOS-Stream-10x86_64✅ passed07.10.2026 08:09:1210min 26stest pipeline
CentOS Stream 10 - coreCentOS-Stream-10x86_64✅ passed07.10.2026 08:09:1311min 43stest pipeline
Fedora - baseFedora-latestx86_64✅ passed07.10.2026 08:09:2611min 7stest pipeline
CentOS Stream 9 - baseCentOS-Stream-9x86_64✅ passed07.10.2026 08:09:2312min 58stest pipeline
CentOS Stream 9 - PyTest - baseCentOS-Stream-9x86_64✅ passed07.10.2026 08:09:3013min 43stest pipeline
CentOS Stream 9 - coreCentOS-Stream-9x86_64✅ passed07.10.2026 08:08:4214min 18stest pipeline
RHEL8 - coreRHEL-8.10.0-Nightlyx86_64✅ passed07.10.2026 08:09:2523min 55stest pipeline
RHEL8 - PyTest - baseRHEL-8.10.0-Nightlyx86_64✅ passed07.10.2026 08:09:2623min 35stest pipeline
RHEL10 - baseRHEL-10.2-Nightlyx86_64✅ passed07.10.2026 08:09:2625min 45stest pipeline
RHEL10 - PyTest - coreRHEL-10.2-Nightlyx86_64✅ passed07.10.2026 08:09:2625min 54stest pipeline
CentOS Stream 9 - PyTest - coreCentOS-Stream-9x86_64✅ passed07.10.2026 08:21:3012min 33stest pipeline
RHEL10 - coreRHEL-10.2-Nightlyx86_64✅ passed07.10.2026 08:09:4128min 17stest pipeline
RHEL8 - baseRHEL-8.10.0-Nightlyx86_64✅ passed07.10.2026 08:09:3931min 37stest pipeline
RHEL10 - PyTest - baseRHEL-10.2-Nightlyx86_64✅ passed07.10.2026 08:21:0125min 45stest pipeline
RHEL8 - PyTest - coreRHEL-8.10.0-Nightlyx86_64✅ passed07.10.2026 08:09:2542min 3stest pipeline
RHEL9 - PyTest - baseRHEL-9.8.0-Nightlyx86_64✅ passed07.10.2026 08:09:4246min 22stest pipeline
RHEL9 - PyTest - coreRHEL-9.8.0-Nightlyx86_64✅ passed07.10.2026 08:08:4749min 29stest pipeline
RHEL9 - coreRHEL-9.8.0-Nightlyx86_64✅ passed07.10.2026 08:21:0237min 25stest pipeline
RHEL9 - baseRHEL-9.8.0-Nightlyx86_64✅ passed07.10.2026 08:20:5344min 34stest pipeline

@pkubatrh

pkubatrh commented Oct 7, 2026

Copy link
Copy Markdown
Member Author

[test-all]

dhandzus
dhandzus approved these changes Oct 7, 2026
View reviewed changes

@dhandzus dhandzus left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dhandzus
dhandzus approved these changes Oct 7, 2026
View reviewed changes

@dhandzus dhandzus left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pkubatrh
pkubatrh merged commit 51196d7 into sclorg:master Oct 7, 2026
26 checks passed
@pkubatrh
pkubatrh deleted the update_node branch October 7, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PavolSloboda PavolSloboda PavolSloboda approved these changes
@dhandzus dhandzus dhandzus approved these changes

Assignees

No one assigned

Labels

pr/failing-ci pr/missing-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pkubatrh @PavolSloboda @dhandzus