Skip to content

chore: remove dead pages, components, assets, and styles - #24

Merged
github-actions[bot] merged 6 commits into
devfrom
chore/remove-dead-code
Sep 4, 2026
Merged

github-actions[bot] merged 6 commits into
devfrom
chore/remove-dead-code

Conversation

@whoisaldo

@whoisaldo whoisaldo commented Sep 4, 2026 •

Copy link
Copy Markdown
Member

What & Why

Removes dead code and leftover assets so the repo only carries what the site renders. The parked careers and inquire pages were unrouted, ProductCard and MediaPlaceholder had no importers, the root assets/ folder duplicated public/assets/ under worse names alongside four AI-generated *Context.txt summaries, and the stylesheet still carried marquee, terminal-box, and cyan/pink/yellow token rules from the pre-rebrand design (the "yellow" token was #c084fc, a purple). Data fields and props that only the removed pieces used go with them: Product.images, the per-product detail.accentColor duplicate, the 'branded' cardHero sentinel, portraitPlaceholder, EngineerCard.compact, and never-passed props on GlowButton, IPhoneFrame, and BrowserFrame. The rich presence showcase now uses the shared TerminalFrame instead of a hand-copied duplicate, and the navbar's duplicated active-link expression is one helper.

46 files, +46 / −1,996 lines, about 1.6 MB of binaries removed. No rendered output changes.

One judgement call to flag: this deletes the parked careers page (app/(unused)/_careers) that #23 touched yesterday. It was never routed and is fully recoverable from git. If you would rather keep it parked, say so and I will restore it.

Proof It Works

Built dev (8198de3) and this branch, served both, and captured 16 routes at desktop (1440) and mobile (390) widths with reduced motion, full page. All 32 captures are byte-identical (sha256) between dev and this branch.

Route Desktop Mobile
/, /products, /about, /contact, /engineers, 404 identical identical
all six /products/<id> pages identical identical
all four /engineers/<id> pages identical identical

The only touched markup that a visitor can see is the EternalRichPresence section on /products, shown below. Before and after hash the same, so one image covers both.

Screenshot:

products-rich-presence

Tested

  • npm run build, npm run lint, npx tsc --noEmit --noUnusedLocals --noUnusedParameters, npx prettier --check, npm run check:consistency, npm run check:copy
  • CI=1 npx playwright test against the production build: 7 passed
  • The 32-capture pixel comparison above

Left out on purpose

  • components/products/ProductsShowcase.tsx hand-duplicates product data that already lives in lib/products.ts, and the copies have drifted: tag lists differ for four of six products, EternalRichPresence passes url={null} while the data has eternalrichpresence.dev, and the Eternal2x URL differs in case. Making that page data-driven would change visible content, so it needs a call on which values win.
  • content/engineers/*/bio.md is not rendered anywhere and mirrors lib/engineers.ts, but both AGENT_NOTES.md and PR.md treat it as a source of facts, so it stays.
  • Engineer.portrait.width/height are never read (portraits render with fill), but the PR checklist references them, so they stay.

Checklist

  • npm run build, npm run lint, npm run check:consistency, and npx playwright test pass locally
  • Grepped for copy and data this change makes stale elsewhere (see PR.md); founder/product counts match lib/ data
  • New pages or entries covered in tests/smoke.spec.ts (none added; the stale inquire comment was removed)
  • Images web-sized and EXIF-stripped; dimensions in lib/ data match the files (no images added)
  • Rebased on latest dev
  • No AI co-author trailers ("Co-authored-by: Claude"), "Generated with" lines, or session links in commits or this description

@vercel

vercel Bot commented Sep 4, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
sideband Ready Ready Preview Sep 4, 2026 4:52am UTC

Request Review

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

This PR changes files that affect what visitors see, but the description has no screenshot.

Run npm run dev, open the affected page, and drag a screenshot of the result into the Proof It Works section (before/after for edits to existing UI). It lets the review happen from the description without checking out the branch.

Not a blocker. If nothing rendered actually changed, say so in the description and ignore this.

Files that triggered this
app/(unused)/_careers/page.tsx
app/(unused)/_inquire/page.tsx
app/engineers/[id]/page.tsx
app/products/[id]/page.tsx
components/engineers/EngineerCard.tsx
components/engineers/FeaturedProjects.tsx
components/inquire/InquireSection.tsx
components/inquire/ProcessStrip.tsx
components/inquire/TicketCard.tsx
components/layout/Navbar.tsx
components/products/DeviceFrames.tsx
components/products/ProductCard.tsx
components/products/ProductDetailPage.tsx
components/products/ProductsShowcase.tsx
components/ui/GlowButton.tsx
components/ui/MediaPlaceholder.tsx
public/assets/EternalSummary/EternalSummaryIcon.png
styles/globals.css

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Screenshots

Auto-captured from this PR's production build (commit 9078810).

Hero Terminal
Hero Terminal
Products Under the hood
Products Under the hood

Studio and CTA

github-actions Bot added a commit that referenced this pull request Sep 4, 2026
@whoisaldo

Copy link
Copy Markdown
Member Author

The screenshot landed in the description a few seconds after this fired (published via scripts/pr-screenshot.sh, pinned to pr-assets 40462a6). Nothing rendered changes in this PR: all 32 before/after captures hash identical, details under Proof It Works.

@naman0r
naman0r requested a lite review from Copilot and removed request for Copilot September 4, 2026 17:33
@whoisaldo
whoisaldo requested a review from naman0r September 4, 2026 17:33
@github-actions
github-actions Bot merged commit b632047 into dev Sep 4, 2026
9 checks passed
@github-actions
github-actions Bot deleted the chore/remove-dead-code branch September 4, 2026 17:35

This branch was successfully deployed

1 active deployment
Preview — 90788106 Deployed Sep 4, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants