Skip to content

Fix failing expectation in tests.test_phase9g_strict_performance_closure #19

Description

@MichaelDecent

Summary

tests.test_phase9g_strict_performance_closure has a failing assertion in test_preserved_artifacts_validate_and_promotion_report_performance_section_is_green.

Reproduction

uv run python -m unittest -v tests.test_phase9g_strict_performance_closure

Current result

  • Ran: 4 tests
  • Failures: 1
  • Failing test:
    • test_preserved_artifacts_validate_and_promotion_report_performance_section_is_green

Failure details

At:

  • tests/test_phase9g_strict_performance_closure.py:74

Assertion:

self.assertFalse(report.passed)

Observed:

  • report.passed is True
  • failure: AssertionError: True is not false

Notes

Other tests in the same module are currently passing, which suggests this is likely expectation drift in this assertion versus the current promotion evaluator/report behavior.

Acceptance criteria

  • Align test expectation with intended current behavior of the promotion report performance section.
  • uv run python -m unittest -v tests.test_phase9g_strict_performance_closure passes.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions