fix(ci): drop removed default_branch input from npm-release trigger - #478
Merged
Merged
Conversation
The shared 0xPolygon/pipelines apps-npm-release.yml workflow removed its default_branch input (it now derives the branch itself), so passing it failed workflow validation — "Invalid input, default_branch is not defined in the referenced workflow" — and broke the Release workflow on push to master. Remove the input (and its now-stale comment); only snapshot_tag remains.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Releaseworkflow failed at validation on push tomaster:The shared reusable workflow
0xPolygon/pipelines/.github/workflows/apps-npm-release.ymlremoved itsdefault_branchinput — it now accepts onlysnapshot_tagand derives the branch itself. Our trigger still passeddefault_branch: master, so GitHub rejected the workflow before any job ran. Releases onmasterare blocked until this lands.Fix
Remove the
default_branchinput (and its now-stale explanatory comment) from thewith:block. Onlysnapshot_tagremains, matching the reusable workflow's current input contract. No behavioural change to the release/snapshot logic — the shared workflow already resolves the branch on its own.