Repository navigation
Conversation
4 of 5 tasks
tozes
force-pushed
the
firmware/amoled-true-black
branch
from
October 10, 2026 07:20
909c10c to
1562f56
Compare
An AMOLED pixel that is off draws no power, but the UI painted its background near black (rgb565(10,14,20)), so every background pixel was lit. DisplayInfo gains `emissive`; AmoledDisplay sets it (the 1.75, 1.75C and 1.8), and Ui uses black for the background on emissive panels. Backlit LCDs keep the near-black background, and the grey top and bottom bars on rectangular panels stay as they are. Test: "display: an emissive panel leaves its background unlit; a backlit one keeps near black".
tozes
force-pushed
the
firmware/amoled-true-black
branch
from
October 10, 2026 07:40
1562f56 to
5a098db
Compare
tozes
marked this pull request as ready for review
October 10, 2026 13:56
Contributor
Author
|
Thanks for the quick reviews and the follow-up fixes on #103–#105. A heads-up on what's coming: #106, #109 and #111 are the next three, and I have more 1.75C work lined up after them (battery indicator, Wi-Fi backoff, battery curves, light sleep, and two plugin changes). Those are open as drafts (#107, #108, #110, #112–#116) so you can see where it's going, but there's no need to look at them yet. I'll mark them ready a few at a time as these merge, so the review load stays manageable. If you'd prefer a different pace or order, or want any of them scoped differently, just lmk. I'm excited about this project and would love to keep contributing. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
An AMOLED pixel that is off draws no power, but the UI painted its background near black (
rgb565(10,14,20)), so every background pixel was lit.DisplayInfogainsemissive;AmoledDisplaysets it (the 1.75, 1.75C and 1.8), andUidraws the background black on emissive panels. Backlit LCDs keep the near-black background, and the grey bars on rectangular panels stay.Part of a series for the AMOLED-1.75C; the physical report is #103.
How you know it works
Tests on this branch (based on
8069101):hermes-gadget build-sim --test: core 122/122. The new "display: an emissive panel leaves its background unlit; a backlit one keeps near black".pytestwithout the simulator-window tests (no virtual display here): 269 passed, 29 skipped.pio runbuilds:esp32s3-touch-amoled-175c,esp32s3-touch-amoled-18. CI builds every board.Board: Waveshare ESP32-S3-Touch-AMOLED-1.75C, SKU 33691 (the unit in #103), with Hermes v0.21.6+199.g1744a19 on Fedora 44. The checks ran on builds of a working branch that combined this change with the others in this series (
30f8bc0); this branch's own image was not installed on its own.Physical: the background looked true black on the 1.75C, with nothing else visibly changed.
Documentation and sources
docs/porting.md(whatemissivemeans for a display driver) and a changelog line.Checklist