Repository navigation
fix(probe): fall back to the base credential pool per provider and keep the vendor check time - #43
Merged
Merged
Conversation
…ep the vendor check time A named profile with no rows for a provider now reads the base home's rows, as Hermes does, so the Claude card stays on profiles that run on the base login (#36). Probe snapshots carry observed_at from the vendor response through the probe cache, and the page and popup show that time instead of the time the UI asked (#40).
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes, one for #36 and one for the part of #40 left open after #41.
Profiles without their own Claude rows (#36)
A named profile with no
credential_poolrows for a provider now reads the base home's rows, the same rule Hermes'sread_credential_pool()uses. That holds even when the profile has anauth.jsonof its own for other providers, so the Claude card no longer disappears on a profile that runs on the base Claude login. The change stays inside_pool_entries()..envlookups, caches and.anthropic_oauth.jsonstay per-profile.Real check time through the probe cache (#40)
Each probe snapshot now carries
observed_at, the time the vendor answered. The probe cache keeps it, and caches written before this change get theirfetched_at. The page's "checked" label and the popup's checked time and stale marker use the oldest observation behind the cards (observedAt), not the time the UI asked.checkedAtstays the request time, so polling and the 24-hour popup snapshot behave as before. The popup snapshot savesobservedAttoo.Tests
test_profile_pool_fallback.py: a profile with noauth.json, a profile whoseauth.jsononly has another provider, a profile with its own Claude rows, and a home outsideprofiles/. Also coversobserved_atsurviving a cache read and old entries being backfilled.test_quick_usage.cjs:probeObservedAtpicks the oldest valid observation, and the saved popup snapshot keeps it.observed_at, so their exact-equality checks still hold.build_catalog.py --checkand theHERMES_TEST_CATALOG=1run.Closes #36