Repository navigation
v0.0.44 #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.0.44 #339
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,3 +22,6 @@ dist-ssr | |
| *.njsproj | ||
| *.sln | ||
| *.sw? | ||
|
|
||
| # Sentry Config File | ||
| .env.sentry-build-plugin | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,16 @@ | ||
| import { StrictMode } from "react"; | ||
| import ReactDOM from "react-dom/client"; | ||
| import { RouterProvider, createRouter } from "@tanstack/react-router"; | ||
| import * as Sentry from "@sentry/react"; | ||
| import "./index.css"; | ||
|
|
||
| // Initialize Sentry for error tracking | ||
| Sentry.init({ | ||
| dsn: "https://9d87ba0a2f4279c02f059509b276419d@o4510748532342784.ingest.us.sentry.io/4510748533194752", | ||
| sendDefaultPii: true, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. style: Prompt To Fix With AIThis is a comment left during a code review.
Path: apps/app/src/main.tsx
Line: 10:10
Comment:
**style:** `sendDefaultPii: true` sends personally identifiable information (PII) to Sentry, including user IPs, usernames, and other identifying data. Verify this complies with your privacy policy and data regulations (GDPR, CCPA, etc).
How can I resolve this? If you propose a fix, please make it concise. |
||
| enableLogs: true, | ||
| }); | ||
|
|
||
| // Import the generated route tree | ||
| import { routeTree } from "./routeTree.gen"; | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| import { sentryVitePlugin } from "@sentry/vite-plugin"; | ||
| import { serwist } from "@serwist/vite"; | ||
| import react from "@vitejs/plugin-react-swc"; | ||
| import { defineConfig } from "vite"; | ||
|
|
@@ -6,23 +7,27 @@ import path from "path"; | |
|
|
||
| // https://vitejs.dev/config/ | ||
| export default defineConfig({ | ||
| plugins: [ | ||
| tanstackRouter({ | ||
| target: "react", | ||
| autoCodeSplitting: true, | ||
| }), | ||
| react(), | ||
| serwist({ | ||
| swSrc: "src/sw.ts", | ||
| swDest: "sw.js", | ||
| globDirectory: "dist", | ||
| injectionPoint: "self.__SW_MANIFEST", | ||
| rollupFormat: "iife", | ||
| }), | ||
| ], | ||
| plugins: [tanstackRouter({ | ||
| target: "react", | ||
| autoCodeSplitting: true, | ||
| }), react(), serwist({ | ||
| swSrc: "src/sw.ts", | ||
| swDest: "sw.js", | ||
| globDirectory: "dist", | ||
| injectionPoint: "self.__SW_MANIFEST", | ||
| rollupFormat: "iife", | ||
| }), sentryVitePlugin({ | ||
| org: "sixhuman-es", | ||
| project: "web-app" | ||
| })], | ||
|
Comment on lines
+19
to
+22
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. style: Missing Prompt To Fix With AIThis is a comment left during a code review.
Path: apps/app/vite.config.ts
Line: 19:22
Comment:
**style:** Missing `authToken` configuration. Check that `SENTRY_AUTH_TOKEN` is set in your CI/CD environment and local `.env.sentry-build-plugin` file for source map uploads to work.
How can I resolve this? If you propose a fix, please make it concise. |
||
|
|
||
| resolve: { | ||
| alias: { | ||
| "@": path.resolve(__dirname, "."), | ||
| }, | ||
| }, | ||
| }); | ||
|
|
||
| build: { | ||
| sourcemap: true | ||
| } | ||
| }); | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: DSN is hardcoded and exposed in client-side code. While DSNs are considered public, consider moving to an environment variable for easier management across environments (dev/staging/prod).
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Prompt To Fix With AI