Skip to content

fix(codex): register marketplace plugin lifecycle hooks - #1

Merged
AlexCawl merged 11 commits into
mainfrom
fix/codex-plugin-hooks
Oct 9, 2026
Merged

AlexCawl merged 11 commits into
mainfrom
fix/codex-plugin-hooks

Conversation

@AlexCawl

@AlexCawl AlexCawl commented Oct 7, 2026 •

Copy link
Copy Markdown
Owner

Installing Caveman from the Codex marketplace exposes its skills but does not register activation hooks. Move the Codex manifest and its existing icons to the marketplace root and declare inline SessionStart and UserPromptSubmit hooks using the existing handlers and readable Node commands.

Codex stores mode changes per chat in PLUGIN_DATA. Startup/clear apply the configured default; resume/compact preserve the selected style or explicit off. Native $skill and Markdown skill references use the shared parser. Invalid session ids fail open, and Codex skips Claude statusline setup, model overrides, and usage scripts.

Remove the repository-local hook configuration to prevent duplicate activation. Keep the standalone Codex loader and installer introduced in main. The Claude plugin manifest, launch commands, Windows behavior, standalone installer, and OpenCode behavior are unchanged. No dependencies or version bump are added.

Upstream issue: #1242.
Upstream pull request: #1243.

Validation:

  • 133 focused tests passed on Node 18, including Codex lifecycle, standalone installation, Claude SDK/subagents, and existing hook path tests.
  • 35 Python activation tests, 44 Python mode-tracking tests, and all 16 standalone JavaScript suites passed.
  • python3 tests/verify_repo.py and git diff --check passed.
  • Full npm test: 575 passed, 17 skipped, one existing macOS/Homebrew failure in standalone hooks keep a stable PATH node symlink, also reproduced on unmodified upstream main (2e08b91).
  • Native marketplace upgrade installed the rebased branch. Codex discovers exactly one SessionStart and one UserPromptSubmit plugin handler in both a consumer project and Caveman, with no warnings or errors; installed files match the checkout.
  • Windows execution is left to the existing CI. Hook trust remains a user action in Codex.

@AlexCawl AlexCawl changed the title fix(codex): load plugin hooks from marketplace installs fix(codex): declare marketplace startup hook inline Oct 7, 2026
@AlexCawl AlexCawl changed the title fix(codex): declare marketplace startup hook inline fix(codex): move plugin manifest to marketplace root Oct 7, 2026
@AlexCawl AlexCawl changed the title fix(codex): move plugin manifest to marketplace root feat(codex): reuse shared mode hooks Oct 7, 2026
@AlexCawl
AlexCawl force-pushed the fix/codex-plugin-hooks branch from 12db595 to 0f8ff88 Compare October 9, 2026 18:34
@AlexCawl AlexCawl changed the title feat(codex): reuse shared mode hooks fix(codex): register marketplace plugin lifecycle hooks Oct 9, 2026
@AlexCawl
AlexCawl marked this pull request as ready for review October 9, 2026 18:49
@AlexCawl
AlexCawl merged commit 41814fc into main Oct 9, 2026
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant