Skip to content

fix(rl): classify zero-variance windows by reward quality - #114

Merged
Algorineko merged 1 commit into
Algorineko:mainfrom
jasonchen505:codex/fix-grpo-zero-variance-quality
Oct 17, 2026
Merged

Algorineko merged 1 commit into
Algorineko:mainfrom
jasonchen505:codex/fix-grpo-zero-variance-quality

Conversation

@jasonchen505

@jasonchen505 jasonchen505 commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

RewardVarianceGuard classifies zero variance as failure before grace_steps and saturation afterward. This misclassifies early all-correct windows and late uniformly failing windows.

Use the entire patience window's reward quality and rollout health to distinguish saturation from failure. Reset the window after informative groups and retain the constructor argument for compatibility.

Validation:

  • Nine deterministic CPU cases cover early/late windows, partial credit, rollout errors, missing/nonfinite rewards, and window reset.
  • Full CPU suite with external HTTP/HF access disabled: 842 passed, 7 skipped.

@Algorineko
Algorineko merged commit b6b30e9 into Algorineko:main Oct 17, 2026
3 checks passed
Algorineko added a commit that referenced this pull request Oct 31, 2026
…e-quality

fix(rl): classify zero-variance windows by reward quality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants