Skip to content

[O2B-1597] Allow user input to accept milliseconds when creating a QC flag from form#2192

Merged
graduta merged 4 commits into
mainfrom
feature/O2B-1597/allow-milliseconds-in-qc-flag-creation
Jul 16, 2026
Merged

[O2B-1597] Allow user input to accept milliseconds when creating a QC flag from form#2192
graduta merged 4 commits into
mainfrom
feature/O2B-1597/allow-milliseconds-in-qc-flag-creation

Conversation

@graduta

@graduta graduta commented Jul 16, 2026

Copy link
Copy Markdown
Member

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • QC Flag Creation form now displays and expects usage of milliseconds as well.
  • By default, the form will contain the start of run time/data taking time up to the milliseconds precision

@graduta graduta self-assigned this Jul 16, 2026
@graduta graduta requested a review from isaachilly as a code owner July 16, 2026 14:04
@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.00%. Comparing base (43cbbcf) to head (c623fdb).

Files with missing lines Patch % Lines
...nents/common/form/inputs/DateTimeInputComponent.js 0.00% 8 Missing ⚠️
lib/public/views/Runs/format/formatRunEnd.js 0.00% 5 Missing ⚠️
lib/public/views/Runs/format/formatRunStart.js 0.00% 5 Missing ⚠️
...ents/common/form/inputs/TimeRangeInputComponent.js 0.00% 4 Missing ⚠️
...ents/Filters/common/filters/TimeRangeInputModel.js 0.00% 3 Missing ⚠️
...omponents/common/form/inputs/DateTimeInputModel.js 0.00% 3 Missing ⚠️
...public/views/QcFlags/Create/QcFlagCreationModel.js 0.00% 3 Missing ⚠️
...ic/views/QcFlags/Create/qcFlagCreationComponent.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2192      +/-   ##
==========================================
- Coverage   46.02%   46.00%   -0.03%     
==========================================
  Files        1039     1039              
  Lines       17180    17189       +9     
  Branches     3140     3146       +6     
==========================================
  Hits         7907     7907              
- Misses       9273     9282       +9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@graduta graduta merged commit 9bc3ef9 into main Jul 16, 2026
22 of 24 checks passed
@graduta graduta deleted the feature/O2B-1597/allow-milliseconds-in-qc-flag-creation branch July 16, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

1 participant