Skip to content

[PWGCF] Add task for correlation study with MPI proxy event classification#17132

Merged
EmilGorm merged 1 commit into
AliceO2Group:masterfrom
EmilGorm:master
Jul 21, 2026
Merged

[PWGCF] Add task for correlation study with MPI proxy event classification#17132
EmilGorm merged 1 commit into
AliceO2Group:masterfrom
EmilGorm:master

Conversation

@EmilGorm

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot added the pwgcf label Jul 20, 2026
@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 1 errors, ⚠️ 0 warnings, 🔕 1 disabled

@github-actions github-actions Bot changed the title Add task for correlation study with MPI proxy event classification [PWGCF] Add task for correlation study with MPI proxy event classification Jul 20, 2026
@EmilGorm
EmilGorm force-pushed the master branch 4 times, most recently from 0e0f1d1 to 6d72155 Compare July 20, 2026 18:13
@EmilGorm
EmilGorm marked this pull request as ready for review July 20, 2026 18:19
@EmilGorm

EmilGorm commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator Author

O2Linter error related to other workflow names in CMakeLists.txt

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 6d72155 at 2026-07-20 20:28:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 24 errors and 36 warnings.'
Found 24 errors and 36 warnings.
++ [[ 24 -gt 0 ]]
++ cat /sw/BUILD/16d04015a1011b1afd5fb5a7c594c5c4d6a500aa/O2Physics-code-check/errors.txt
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:48:1: error: included header TH1D.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:51:1: error: included header TMath.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:52:1: error: included header TVector2.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:76:18: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:78:8: error: constructor does not initialize these fields: multCutFormulaParamIndex, ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:104:63: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:206:11: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:208:11: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:210:11: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:212:11: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:214:11: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:378:33: error: the parameter 'target' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:378:52: error: the parameter 'collision' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:663:47: error: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:666:34: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:675:50: error: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:678:37: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:692:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:697:31: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:715:56: error: no header providing "Form" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:860:60: error: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:944:78: error: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:1044:5: error: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:1057:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
++ [[ 36 -gt 0 ]]
++ cat /sw/BUILD/16d04015a1011b1afd5fb5a7c594c5c4d6a500aa/O2Physics-code-check/warnings.txt
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:203:40: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:206:62: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:208:62: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:210:67: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:212:71: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:214:62: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:292:48: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:330:111: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:352:119: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:357:150: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:430:41: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:433:98: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:444:71: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:505:122: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:509:54: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:517:75: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@EmilGorm
EmilGorm marked this pull request as draft July 20, 2026 18:51
@EmilGorm
EmilGorm marked this pull request as ready for review July 21, 2026 06:22
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 03fb690 at 2026-07-21 08:29:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:74:98: error: too many initializers for 'std::array<float, 1>'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:719:30: error: no matching function for call to 'THn::GetBinContent(std::array<int, 4>&)'
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 03fb690 at 2026-07-21 08:31:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:74:98: error: too many initializers for 'std::array<float, 1>'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:719:30: error: no matching function for call to 'THn::GetBinContent(std::array<int, 4>&)'
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for ee5d5ed at 2026-07-21 08:44:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 1 errors and 0 warnings.'
Found 1 errors and 0 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/45758bba9861933a56af420d3a7c1f6da9644acf/O2Physics-code-check/errors.txt
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:714:5: error: uninitialized record type: 'effVars' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

@EmilGorm
EmilGorm enabled auto-merge (squash) July 21, 2026 07:33
@EmilGorm
EmilGorm merged commit 084cc23 into AliceO2Group:master Jul 21, 2026
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants