Skip to content

fix(dashboard): keep pip install dialog visible in console fullscreen - #10608

Merged
Soulter merged 1 commit into
AstrBotDevs:masterfrom
mantoujun12:fix/10603
Oct 20, 2026
Merged

Soulter merged 1 commit into
AstrBotDevs:masterfrom
mantoujun12:fix/10603

Conversation

@mantoujun12

@mantoujun12 mantoujun12 commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

在 Web UI 的“数据与日志 → 日志”页面进入浏览器原生全屏后,点击“安装 Pip 库”不会立即显示弹窗,退出全屏后弹窗才会出现。原因是 Vuetify 的 v-dialog 默认会将弹层 teleport 到 body,而浏览器原生全屏只显示全屏元素内部的节点,导致已经打开的弹窗位于全屏层之外。

Fixes #10603

Modifications / 改动点

  • 在 dashboard/src/views/ConsolePage.vue 中为“安装 Pip 库”弹窗增加 attach="#console-wrapper",将 Vuetify overlay 挂载到日志全屏容器内部,确保全屏状态下也能正常显示弹窗。

  • 未调整日志页布局、按钮位置或其他交互逻辑。

  • This is NOT a breaking change. / 这不是一个破坏性变更。

Screenshots or Test Results / 运行截图或测试结果

image

验证步骤:

  1. 打开 Web UI,进入“数据与日志 → 日志”。
  2. 点击日志区域右上角的全屏按钮。
  3. 在全屏状态下点击“安装 Pip 库”。
  4. 确认弹窗立即显示,并且可以正常输入包名、镜像地址和提交安装。
  5. 退出全屏后再次打开弹窗,确认非全屏状态未受影响。
  6. 执行 pnpm typecheck 和 git diff --check,确认静态检查通过。

测试结果:

pnpm typecheck 通过,git diff --check 通过。


Checklist / 检查清单

  • 😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
    / 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。

  • 👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
    / 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”。

  • 📚 I checked the affected WebUI instructions and screenshots in docs/zh and docs/en against the changed navigation, page structure, and labels, and updated them in this PR (or explained why no documentation update is needed). For renamed, moved, or merged entry points, I included an old entry → new entry mapping in the documentation and changelog.
    / 我已对照变化后的 WebUI 入口、页面结构和术语,核对并在本 PR 中更新 docs/zh 和 docs/en 的相关操作说明与截图(或说明无需更新文档的原因)。入口改名、移动或合并时,已在文档和 changelog 中补充 旧入口 → 新入口 对照。

  • 🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in requirements.txt and pyproject.toml.
    / 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到 requirements.txt 和 pyproject.toml 文件相应位置。

  • 😮 My changes do not introduce malicious code.
    / 我的更改没有引入恶意代码。

Summary by Sourcery

Bug Fixes:

  • Keep the Pip installation dialog visible and usable while the console is in browser fullscreen mode.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@mantoujun12 mantoujun12 changed the title fix(webui): keep pip install dialog visible in console fullscreen fix(dashboard): keep pip install dialog visible in console fullscreen Oct 20, 2026
@Soulter
Soulter merged commit 776793b into AstrBotDevs:master Oct 20, 2026
23 checks passed
@mantoujun12
mantoujun12 deleted the fix/10603 branch October 20, 2026 05:50
BegoniaHe pushed a commit to Xero-Team/AstrBot that referenced this pull request Oct 20, 2026
…trBotDevs#10608)

Upstream-Commit: 776793b
Upstream-Author: 一张白纸 <202384594+mantoujun12@users.noreply.github.com>
Upstream-PR: AstrBotDevs#10608
Sync-Disposition: adapt
Fork-Adaptation: Applied the dialog attach target to the fork LogsPage and added the matching id to the shared ConsoleDisplayer root, which owns the fullscreen element.
Tested: cd dashboard && pnpm typecheck; pnpm exec vitest run --config vitest.config.ts tests/remainingCoverage.vitest.ts
AI-Generated: true
Generated-At: 2026-10-20T10:28:10Z
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Web UI 日志界面在全屏状态下,点击 安装 Pip 库 不会弹窗

2 participants