Skip to content

fix: preserve trace snapshot ordering across clock corrections - #10617

Open
wcqqq1214 wants to merge 3 commits into
AstrBotDevs:masterfrom
wcqqq1214:fix/core-restart-test-timeout
Open

wcqqq1214 wants to merge 3 commits into
AstrBotDevs:masterfrom
wcqqq1214:fix/core-restart-test-timeout

Conversation

@wcqqq1214

@wcqqq1214 wcqqq1214 commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Fix stale trace summaries and lost completion updates when the wall clock repeats or moves backward.

Modifications / 改动点

  • Keep snapshot timestamps increasing within each trace.

  • Add regression coverage for frozen/backward clocks, ordered/reversed snapshots, and running/completed traces.

  • This is NOT a breaking change. / 这不是一个破坏性变更。

Screenshots or Test Results / 运行截图或测试结果

  • Clock regression tests: 8 passed. Run: uv run --no-sync pytest tests/unit/test_trace_store.py -k clock_corrections -q.
  • Trace, lifecycle, and dashboard tests: 247 passed.
  • ruff format ., ruff check ., and git diff --check passed.
  • No WebUI changes; screenshots and documentation updates are not applicable.

Checklist / 检查清单

  • 😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
    / 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。

  • 👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
    / 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”。

  • 📚 I checked the affected WebUI instructions and screenshots in docs/zh and docs/en against the changed navigation, page structure, and labels, and updated them in this PR (or explained why no documentation update is needed). For renamed, moved, or merged entry points, I included an old entry → new entry mapping in the documentation and changelog.
    / 我已对照变化后的 WebUI 入口、页面结构和术语,核对并在本 PR 中更新 docs/zh 和 docs/en 的相关操作说明与截图(或说明无需更新文档的原因)。入口改名、移动或合并时,已在文档和 changelog 中补充 旧入口 → 新入口 对照。

  • 🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in requirements.txt and pyproject.toml.
    / 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到 requirements.txt 和 pyproject.toml 文件相应位置。

  • 😮 My changes do not introduce malicious code.
    / 我的更改没有引入恶意代码。

Summary by Sourcery

Preserve trace snapshot ordering across wall-clock corrections so the latest trace state is not lost.

Bug Fixes:

  • Preserve the latest trace summary and completion state when wall-clock timestamps are frozen or move backward.

Enhancements:

  • Maintain strictly increasing snapshot timestamps within each trace to keep persisted updates ordered correctly.

Tests:

  • Add regression coverage for clock corrections, snapshot ordering, and running versus completed traces.

@wcqqq1214
wcqqq1214 marked this pull request as ready for review October 18, 2026 11:42
sourcery-ai[bot]
sourcery-ai Bot previously approved these changes Oct 18, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@wcqqq1214 wcqqq1214 changed the title test: fix core restart test timeout fix: preserve trace snapshot ordering and stabilize cross-platform tests Oct 18, 2026
@sourcery-ai
sourcery-ai Bot dismissed their stale review October 18, 2026 12:10

Sourcery withdrew this approval because the latest commits introduced blocking findings.

@wcqqq1214

Copy link
Copy Markdown
Contributor Author

@sourcery-ai review

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Needs a human reviewer. If the timestamp logic is wrong, persisted trace snapshots can retain incorrect ordering or timestamps after the code is reverted; those historical values are not automatically repaired. The impact is bounded to trace data and can be addressed by clearing or correcting affected records.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@wcqqq1214 wcqqq1214 changed the title fix: preserve trace snapshot ordering and stabilize cross-platform tests fix: preserve trace snapshot ordering across clock corrections Oct 24, 2026
@wcqqq1214

Copy link
Copy Markdown
Contributor Author

@sourcery-ai review

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Needs a human reviewer. The updated timestamp is persisted and helps determine which trace snapshot wins, so a faulty calculation could leave a trace with stale ordering or summary data after the code is reverted. The impact is bounded to affected trace records and can be repaired by writing a corrected snapshot.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant