Skip to content

fix: propagate Xinference STT errors and reject empty health checks - #10628

Open
wcqqq1214 wants to merge 1 commit into
AstrBotDevs:masterfrom
wcqqq1214:fix/xinference-stt-test-errors
Open

wcqqq1214 wants to merge 1 commit into
AstrBotDevs:masterfrom
wcqqq1214:fix/xinference-stt-test-errors

Conversation

@wcqqq1214

@wcqqq1214 wcqqq1214 commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Fix Xinference STT model tests reporting success after transcription failures.

Modifications / 改动点

  • Propagate transcription failures, including HTTP errors and connection failures.

  • Reject empty or whitespace-only STT health-check results.

  • This is NOT a breaking change. / 这不是一个破坏性变更。

Screenshots or Test Results / 运行截图或测试结果

  • Local HTTP verification: return 200 with text, then 503, then stop the server. Model tests report available, unavailable, and unavailable, preserving failure details.
  • Empty, whitespace-only, and null transcription checks passed; valid text succeeds.
  • Ruff formatting/lint and 22 existing related tests passed. Backend-only change; no UI screenshots or documentation updates needed.

Checklist / 检查清单

  • 😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
    / 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。

  • 👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
    / 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”。

  • 📚 I checked the affected WebUI instructions and screenshots in docs/zh and docs/en against the changed navigation, page structure, and labels, and updated them in this PR (or explained why no documentation update is needed). For renamed, moved, or merged entry points, I included an old entry → new entry mapping in the documentation and changelog.
    / 我已对照变化后的 WebUI 入口、页面结构和术语,核对并在本 PR 中更新 docs/zh 和 docs/en 的相关操作说明与截图(或说明无需更新文档的原因)。入口改名、移动或合并时,已在文档和 changelog 中补充 旧入口 → 新入口 对照。

  • 🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in requirements.txt and pyproject.toml.
    / 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到 requirements.txt 和 pyproject.toml 文件相应位置。

  • 😮 My changes do not introduce malicious code.
    / 我的更改没有引入恶意代码。

Summary by Sourcery

Ensure STT health checks accurately report Xinference transcription failures and invalid empty results.

Bug Fixes:

  • Propagate Xinference STT initialization, input, HTTP, and connection failures instead of treating them as empty transcriptions.
  • Reject empty or whitespace-only transcriptions during STT health checks.

@wcqqq1214
wcqqq1214 marked this pull request as ready for review October 19, 2026 04:16

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@FireChickenMP4

Copy link
Copy Markdown
Contributor

Tests for these raise paths: wcqqq1214#2

Covers the empty-transcription check and the uninitialized, empty-audio and non-200 cases in the Xinference provider. Tests only, no production changes.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants